-------------------------------------------------------------------------------
Review 001
-------------------------------------------------------------------------------

* (FIXED) The files contain /* $Id$ */ at top. To be removed.

* (FIXED) Replace assert() from disconnect.c with return
  code - RDBI_GENERIC_ERROR.

* (FIXED) FdoRdbmsPostGisProviderInfo.h, the version should be 3.2.0.0
  #define RDBMS_POSTGIS_FDO_VERSION L"1.0.0.0"

* (FIXED) FdoRdbmsPostGisCommandCapabilities.cpp
  You should comment out the commands you do not currently support...

  [GB] FYI: I would recommend that all code submitted to the Subversion
  have accurate capabilities. Users such as MapGuide use these
  capabilities to trigger their logic. If the capabilities are invalid,
  exceptions will occur.

* (FIXED) Move all implementation code from headers to translation units (.cpp)

* (FIXED) OK, I use assertions only for development+testing purpose.
  I'll remove all asserts before merging PostGIS FDO branch to the 'trunk'.

  [GB] I recommend asserting AND returning the error code Dan mentions.
  In Debug mode you will easily find the issue due to the assert. In release
  mode we will get back an error message we can return to the user.

* (FIXED) FdoRdbmsPostGisFilterProcessor::ProcessSpatialCondition()
  FdoStringP columnName = GetGeometryColumnNameForProperty(geomProp,
  true);
  Greg states the use of true as a second argument results in a memory leak.
  I send my understanding of this issue to Gary, I don't see any bug here. 

* (FIXED) FdoRdbmsPostGisProviderInfo.cpp FDORDBMS_472 and FDORDBMS_473 need to
  be replaced with PostGIS equivalents.
  mloskot: generate appropriate numbers for PostGIS in NLS files
  mloskot: new values are FDORDBMS_483 and FDORDBMS_484

* (FIXED) FdoRdbmsPostGisFilterProcessor::ProcessSpatialCondition()

  FdoGeometryValue *geom = dynamic_cast<FdoGeometryValue*>(filter.GetGeometry());
  Not using FdoPtr<FdoGeometryValue> geom will result in a memory leak

  FdoByteArray* geomFgf = NULL; geomFgf = geom->GetGeometry();

  Not using FdoPtr<FdoByteArray> geomFgf = geom->GetGeometry() will
  result in a memory leak.

  FdoIGeometry* geometryObj = NULL;
  geometryObj = gf->CreateGeometryFromFgf(geomFgf);

  Not using FdoPtr<FdoIGeometry> geometryObj = gf->CreateGeometryFromFgf(geomFgf)
  will result in a memory leak.


-------------------------------------------------------------------------------
Review 002
-------------------------------------------------------------------------------

* Use Unit Tests to test Rdbi

* Create Visual Studio .sln file in .../Src/PostGIS that contains all the .vcproj
  files and their build order?

* Create PostGisDriver.vcproj from scratch.

* Build on Windows

* Write HOWTO build PostGIS + FDO on Windows


-------------------------------------------------------------------------------
BEFORE MERGING WITH TRUNK
-------------------------------------------------------------------------------

* Remove MySQL references from comments

* Remove ALL asserts