Details Ticket 5094


Comment | Reply | Take | Resolve


Serial Number 5094
Subject r.support from the GUI is broken
Area grass6
Queue grass
Requestors hamish_nospam@yahoo.com
Owner none
Status open
Last User Contact Sat Nov 4 19:29:28 2006 (2 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Sun Nov 5 04:21:25 2006 (2 yr ago)
Created Mon Sep 4 04:51:05 2006 (2 yr ago)

Transaction History Ticket 5094


Mon, Sep 4 2006 04:51:05    Request created by hbowman  
Subject: r.support from the GUI is broken

Hi,

If you launch r.support (r.support.sh actually) from the gis.m menu, you get
to pick a map and then launch r.support in an xterm. As soon as you enter "y"
or "n" at the prompt the xterm disappears. Replace "execute r.support.sh" with
"term r.support" on line ~421 of menu.tcl for comparison with what should happen.
The grass-run.sh script pauses if the module exited with an error. Maybe
grass-xterm-wrapper should too?  (this doesn't seem to help with the r.support
problem though)


Hamish
Mon, Sep 4 2006 19:33:04    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17660.25417.983800.547612@cerise.gclements.plus.com>
Date Mon, 4 Sep 2006 18:32:57 +0100
To Request Tracker <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5094] (grass) r.support from the GUI is broken
In-Reply-To <20060904025105.1D2781005B4@lists.intevation.de>
References <20060904025105.1D2781005B4@lists.intevation.de>
X-Mailer VM 7.07 under 21.4 (patch 15) "Security Through Obscurity" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Level
Request Tracker wrote:

> this bug's URL: http://intevation.de/rt/webrt?serial_num=5094

> Subject: r.support from the GUI is broken

> The grass-run.sh script pauses if the module exited with an error. Maybe
> grass-xterm-wrapper should too?  (this doesn't seem to help with the r.support
> problem though)

There is no point doing it in grass-xterm-wrapper, for several
reasons:

1. grass-xterm-wrapper's stdout will typically be the pipe set up by
Tcl's "exec" or "open |..." commands, its stderr will either refer to
the same pipe or be redirected to /dev/null, and it won't have a
stdin.

2. Once $GRASS_XTERM completes, the terminal window has gone; there
doesn't seem to be much point pausing here.

3. xterm's exit code doesn't reflect the exit code of the program
which is run via -e, so grass-xterm-wrapper doesn't know whether the
command succeeded or failed.

4. Anything which d.m/gis.m run via an xterm needs to use grass-run.sh
(otherwise the program may be unable to find the GRASS shared
libraries), which already includes the pause.

-- 
Glynn Clements <glynn@gclements.plus.com>


Wed, Sep 27 2006 14:38:38    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Thu, 28 Sep 2006 00:38:28 +1200
From Hamish <hamish_nospam@yahoo.com>
To grass5 <grass-dev@grass.itc.it>
Cc grass-bugs@intevation.de
Subject Re: [GRASS-dev] [bug #5094] (grass) r.support from the GUI is broken
Message-Id <20060928003828.309c5c95.hamish_nospam@yahoo.com>
X-Mailer Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-2.3 tagged_above=-999 required=3 tests=[BAYES_00=-5, FORGED_YAHOO_RCVD=2.7]
X-Spam-Level
> this bug's URL: http://intevation.de/rt/webrt?serial_num=5094

> If you launch r.support (r.support.sh actually) from the gis.m menu,
> you get to pick a map and then launch r.support in an xterm. As soon
> as you enter "y" or "n" at the prompt the xterm disappears. Replace
> "execute r.support.sh" with "term r.support" on line ~421 of menu.tcl
> for comparison with what should happen.


After some debugging:

if you answer "Y", it breaks in r.support/front/run.c run_etc_support():
    G_snprintf(buf, sizeof(buf), "%s/etc/support/%s '%s'",
             G_gisbase(), pgm, rast);


if you answer "N", it breaks in r.support/front/check.c check_stats()
    G_snprintf(question, sizeof(question), _("Update the statistics "
             "(histogram, range) for [%s]? "), name);


??


For now I'm setting this to "term" mode in menu.tcl in the 6.2 release
branch while we work out a fix in HEAD.


Hamish


Thu, Sep 28 2006 20:33:46    Mail sent by rez@touchofmadness.com  
Return-Path <rez@touchofmadness.com>
Delivered-To grass-bugs@lists.intevation.de
Subject Re: [GRASS-dev] [bug #5094] (grass) r.support from the GUI is broken
From Brad Douglas <rez@touchofmadness.com>
Reply-To rez@touchofmadness.com
To Hamish <hamish_nospam@yahoo.com>
Cc grass5 <grass-dev@grass.itc.it>, grass-bugs@intevation.de
In-Reply-To <20060928003828.309c5c95.hamish_nospam@yahoo.com>
References <20060928003828.309c5c95.hamish_nospam@yahoo.com>
Content-Type text/plain
Date Thu, 28 Sep 2006 11:33:18 -0700
Message-Id <1159468398.2617.88.camel@devel>
Mime-Version 1.0
X-Mailer Evolution 2.6.3 (2.6.3-1.fc5.5)
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Level
On Thu, 2006-09-28 at 00:38 +1200, Hamish wrote:
> > this bug's URL: http://intevation.de/rt/webrt?serial_num=5094
> 
> > If you launch r.support (r.support.sh actually) from the gis.m menu,
> > you get to pick a map and then launch r.support in an xterm. As soon
> > as you enter "y" or "n" at the prompt the xterm disappears. Replace
> > "execute r.support.sh" with "term r.support" on line ~421 of menu.tcl
> > for comparison with what should happen.
> 
> 
> After some debugging:
> 
> if you answer "Y", it breaks in r.support/front/run.c run_etc_support():
>     G_snprintf(buf, sizeof(buf), "%s/etc/support/%s '%s'",
>              G_gisbase(), pgm, rast);
> 
> 
> if you answer "N", it breaks in r.support/front/check.c check_stats()
>     G_snprintf(question, sizeof(question), _("Update the statistics "
>              "(histogram, range) for [%s]? "), name);
> 
> 
> ??
> 
> 
> For now I'm setting this to "term" mode in menu.tcl in the 6.2 release
> branch while we work out a fix in HEAD.

I'm about half way through rewriting r.support (been in that state for
awhile, now).  I'm splitting up the functionality into individual
modules and removing interactivity.  A few of the modules are done, but
I'm waiting for them all to be done before committing to CVS.


-- 
Brad Douglas <rez touchofmadness com>                      KB8UYR
Address: 37.493,-121.924 / WGS84    National Map Corps #TNMC-3785


Fri, Sep 29 2006 19:09:06    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17693.21289.725658.388558@cerise.gclements.plus.com>
Date Fri, 29 Sep 2006 18:08:57 +0100
To rez@touchofmadness.com
Cc Hamish <hamish_nospam@yahoo.com>, grass-bugs@intevation.de, grass5 <grass-dev@grass.itc.it>
Subject Re: [GRASS-dev] [bug #5094] (grass) r.support from the GUI is broken
In-Reply-To <1159468398.2617.88.camel@devel>
References <20060928003828.309c5c95.hamish_nospam@yahoo.com> <1159468398.2617.88.camel@devel>
X-Mailer VM 7.07 under 21.4 (patch 15) "Security Through Obscurity" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Level
Brad Douglas wrote:

> > > If you launch r.support (r.support.sh actually) from the gis.m menu,
> > > you get to pick a map and then launch r.support in an xterm. As soon
> > > as you enter "y" or "n" at the prompt the xterm disappears. Replace
> > > "execute r.support.sh" with "term r.support" on line ~421 of menu.tcl
> > > for comparison with what should happen.
> > 
> > 
> > After some debugging:
> > 
> > if you answer "Y", it breaks in r.support/front/run.c run_etc_support():
> >     G_snprintf(buf, sizeof(buf), "%s/etc/support/%s '%s'",
> >              G_gisbase(), pgm, rast);
> > 
> > 
> > if you answer "N", it breaks in r.support/front/check.c check_stats()
> >     G_snprintf(question, sizeof(question), _("Update the statistics "
> >              "(histogram, range) for [%s]? "), name);
> > 
> > 
> > ??
> > 
> > 
> > For now I'm setting this to "term" mode in menu.tcl in the 6.2 release
> > branch while we work out a fix in HEAD.
> 
> I'm about half way through rewriting r.support (been in that state for
> awhile, now).  I'm splitting up the functionality into individual
> modules and removing interactivity.  A few of the modules are done, but
> I'm waiting for them all to be done before committing to CVS.

I suggest committing them as they are done. Regardless of the presence
or absence of r.support, the individual modules are useful in their
own right.

[Otherwise, r.region wouldn't exist.]

-- 
Glynn Clements <glynn@gclements.plus.com>


Sat, Nov 4 2006 19:29:28    Mail sent by mneteler  
Hi Hamish,

is the problem solved?

Markus

Sun, Nov 5 2006 04:21:25    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Sun, 5 Nov 2006 16:21:20 +1300
From Hamish <hamish_nospam@yahoo.com>
To Markus Neteler via RT <grass-bugs@intevation.de>
Subject Re: [bug #5094] (grass) r.support from the GUI is broken
Message-Id <20061105162120.033f5187.hamish_nospam@yahoo.com>
In-Reply-To <20061104182928.D9B7C101F00@lists.intevation.de>
References <20061104182928.D9B7C101F00@lists.intevation.de>
X-Mailer Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-2.3 tagged_above=-999 required=3 tests=[BAYES_00=-5, FORGED_YAHOO_RCVD=2.7]
X-Spam-Level
> is the problem solved?

no.

For now I made r.support run in old text parser mode to select the map.

You should be able to select map with GUI window, then have that launch
an xterm. But then the xterm dies after the [y/n] prompt.



Hamish


Comment | Reply | Take | Resolve

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request