Details Ticket 5215


Comment | Reply | Take | Resolve


Serial Number 5215
Subject r.los module crashes (Windows)
Area grass6
Queue grass
Requestors balazovic@mailbox.sk
Owner none
Status open
Last User Contact Thu Nov 30 00:43:47 2006 (2 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Thu Nov 30 00:43:47 2006 (2 yr ago)
Created Tue Oct 17 21:02:31 2006 (2 yr ago)

Transaction History Ticket 5215


Tue, Oct 17 2006 21:02:31    Request created by guest  
Subject: r.los module crashes (Windows)

Platform: WindowsNT/2000/XP
grass obtained from: Other (CDROM etc)
grass binary for platform: Downloaded precompiled Binaries
GRASS Version: 6.3.CVS

r.los module crashes on Windows. In Linux it works with same input data 
(same elevation raster, same coordinate of observer, same distance). In 
Windows it doesn't crash only for very low max_distance values. This 
behavior was observed using GRASS native WinGRASS and also using GRASS shell
in QauntumGIS 0.8.0 Preview2 (WIN verision).
Thu, Oct 19 2006 01:39:32    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Thu, 19 Oct 2006 12:39:18 +1300
From Hamish <hamish_nospam@yahoo.com>
To Request Tracker <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5215] (grass) r.los module crashes (Windows)
Message-Id <20061019123918.06ea9627.hamish_nospam@yahoo.com>
In-Reply-To <20061017190231.135D4101F0D@lists.intevation.de>
References <20061017190231.135D4101F0D@lists.intevation.de>
X-Mailer Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-2.3 tagged_above=-999 required=3 tests=[BAYES_00=-5, FORGED_YAHOO_RCVD=2.7]
X-Spam-Level
> this bug's URL: http://intevation.de/rt/webrt?serial_num=5215
> ---------------------------------------------------------------------
> 
> Subject: r.los module crashes (Windows)
> 
> Platform: WindowsNT/2000/XP
> grass obtained from: Other (CDROM etc)
> grass binary for platform: Downloaded precompiled Binaries
> GRASS Version: 6.3.CVS
> 
> r.los module crashes on Windows. In Linux it works with same input
> data  (same elevation raster, same coordinate of observer, same
> distance). In  Windows it doesn't crash only for very low max_distance
> values. This  behavior was observed using GRASS native WinGRASS and
> also using GRASS shell  in QauntumGIS 0.8.0 Preview2 (WIN verision).


does r.cva (via the GEM extension) work with the Windows port yet?

It's a lot nicer than r.los.


Hamish


Sun, Nov 26 2006 14:59:12    Mail sent by mneteler  
Hello Paul,

[RT: https://intevation.de/rt/webrt?serial_num=5215]
could you give r.los a quick try in your native Windows version?

Maybe the problem is already solved?

thanks,
Markus
Wed, Nov 29 2006 16:46:15    Mail sent by pkelly  
I can confirm that it crashes on Windows when higher values for max_dist are
used. E.g. in spearfish it is OK with max_dist=2500 but crashes for
max_dist=3000. I remember from looking in depth at r.los a few years ago that
the code was quite a mess and really inefficient and, well, I'd rather
re-write it than try to fix it.

Paul
Wed, Nov 29 2006 16:49:16    Comments added by pkelly  
Cc: grass-dev@grass.itc.it

Oh and is there a reason why we can not put r.cva in CVS and replace r.los
with it, perhaps renaming it to r.los? I recall there being some discussion on
the list about that but can't remember the outcome. Was there some objection
from the author? IIRC r.cva fixed a few bugs in r.los as well as greatly
increasing the functionality. Had some very nice documentation too.

Paul
Thu, Nov 30 2006 00:43:47    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Thu, 30 Nov 2006 12:43:34 +1300
From Hamish <hamish_nospam@yahoo.com>
To Paul Kelly via RT <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5215] (grass) r.los module crashes (Windows)
Message-Id <20061130124334.29396f7f.hamish_nospam@yahoo.com>
In-Reply-To <20061129154916.61B0A1005C5@lists.intevation.de>
References <20061129154916.61B0A1005C5@lists.intevation.de>
X-Mailer Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-2.3 tagged_above=-999 required=3 tests=[BAYES_00=-5, FORGED_YAHOO_RCVD=2.7]
X-Spam-Level
Paul Kelly via RT wrote:
> this bug's URL: http://intevation.de/rt/webrt?serial_num=5215
..
> I can confirm that it crashes on Windows when higher values for
> max_dist are used. E.g. in spearfish it is OK with max_dist=2500 but
> crashes for max_dist=3000. I remember from looking in depth at r.los a
> few years ago that the code was quite a mess and really inefficient
> and, well, I'd rather re-write it than try to fix it.

I looked at it in the past as well and came to much the same conclusion.
(I modified it to output azimuth angle instead of elevation angle)

> Oh and is there a reason why we can not put r.cva in CVS and replace
> r.los with it, perhaps renaming it to r.los? I recall there being some
> discussion on the list about that but can't remember the outcome. Was
> there some objection from the author? IIRC r.cva fixed a few bugs in
> r.los as well as greatly increasing the functionality. Had some very
> nice documentation too.

AFAIK the author was in favour of this, but stuck in protracted
negotiations with his employer (a university) WRT releasing the code as
GPL or public domain. Perhaps we can help by preparing a Wiki page
highlighting contributions from other high-profile corporate entities
(e.g. USACE/CERL, Duke Univ, US EPA, Lockheed Martin, UC Berkeley, USGS,
...). For r.cva examples of other U.K. institutions gaining prestige by
contributing to well known open source projects would be good.
e.g. (sort of) http://gpsd.berlios.de/for-vendors.html


Hamish


Comment | Reply | Take | Resolve

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request