Details Ticket 782


Comment | Reply | Open


Serial Number 782
Subject r.out.ascii/r.in.ascii
Area bug
Queue grass
Requestors rshepard@appl-ecosys.com
Owner gclements
Status resolved
Last User Contact Fri Aug 3 05:53:25 2001 (7 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Fri Nov 9 13:03:58 2001 (7 yr ago)
Created Thu Aug 2 21:21:08 2001 (7 yr ago)

Transaction History Ticket 782


Thu, Aug 2 2001 21:21:08    Request created by guest  
Subject: r.out.ascii/r.in.ascii

Platform: Linux/Intel
Linux distro: RedHat
linux cpu: Intel (i486, i586, pentium ...)
Xwindows version: Xfree 3.3.6
Xwindows manager: xfce-3.7.2
TclTk version: n/a
grass downloaded at: CVS Server, Germany
grass binary for platform: I compiled the sources myself
grass sources source: yes, I am using the latest GRASS from CVS
c compiler name: gcc

GRASS:/mnt/usr4/projects/nevada/coeur > r.out.ascii

OPTION:   Name of an existing raster map
     key: input
required: YES

Enter the name of an existing raster file
Enter 'list' for a list of existing raster files
Hit RETURN to cancel request
> unionville_dem
<unionville_dem>

OPTION:   Name of an output ASCII grid map (use out=- for stdout)
     key: output
required: YES

Enter the name of an existing raster file
Enter 'list' for a list of existing raster files
Hit RETURN to cancel request

  Notice that when the input map is named, the option for output map name is
skipped and the input name is requested again. It runs fine after this:

Enter the name of an existing raster file
Enter 'list' for a list of existing raster files
Hit RETURN to cancel request
> unionville_dem
<unionville_dem>

OPTION:   Number of decimal places
     key: dp
 default: 6
required: NO
enter option > 6

You have chosen:
  dp=6
Is this correct? (y/n) [y] 

OPTION:   Char string to represent no data cell
     key: null
 default: *
required: NO
enter option > 

FLAG: Set the following flag?
    Suppress printing of header information?(y/n) [n] 

et cetera.

  BTW, the same bug appears in r.in.ascii. I can file a separate report on that
if so desired. Again, input name is requested. When provided, output name request
flies by on the screen and the input name is again requested. The second time
the module works as advertised.

Rich
Fri, Aug 3 2001 04:26:29    Mail sent by glynn.clements@virgin.net  
Return-Path <glynn.clements@virgin.net>
Delivered-To grass-bugs@mailman.intevation.de
From Glynn Clements <glynn.clements@virgin.net>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <15210.1368.330812.433103@cerise.nosuchdomain.co.uk>
Date Fri, 3 Aug 2001 02:58:48 +0100
To Request Tracker <grass-bugs@intevation.de>
Cc grass5@geog.uni-hannover.de, Rich Shepard <rshepard@appl-ecosys.com>
Subject Re: [GRASS5] [bug #782] (grass) r.out.ascii/r.in.ascii
In-Reply-To <20010802192108.A5064139F6@mailman.intevation.de>
References <20010802192108.A5064139F6@mailman.intevation.de>
X-Mailer VM 6.94 under 21.4 (patch 4) "Artificial Intelligence (candidate #1)" XEmacs Lucid
Request Tracker wrote:

> GRASS:/mnt/usr4/projects/nevada/coeur > r.out.ascii
> 
> OPTION:   Name of an existing raster map
>      key: input
> required: YES
> 
> Enter the name of an existing raster file
> Enter 'list' for a list of existing raster files
> Hit RETURN to cancel request
> > unionville_dem
> <unionville_dem>
> 
> OPTION:   Name of an output ASCII grid map (use out=- for stdout)
>      key: output
> required: YES
> 
> Enter the name of an existing raster file
> Enter 'list' for a list of existing raster files
> Hit RETURN to cancel request
> 
>   Notice that when the input map is named, the option for output map
>   name is skipped and the input name is requested again. It runs fine
>   after this:

It appears that the author didn't quite understand the command-line
parser. That argument has:

    parm.output->gisprompt  = "old,cell,raster" ;

which tells the parser that the "output" argument is the name of an
existing raster map layer (it isn't; it's a filename).

I'll commit a fix to this.

>   BTW, the same bug appears in r.in.ascii. I can file a separate
>   report on that if so desired. Again, input name is requested. When
>   provided, output name request flies by on the screen and the input
>   name is again requested. The second time the module works as
>   advertised.

r.in.ascii may have a bug, but it's not the same bug. Only "output"
has a "gisprompt" value.

-- 
Glynn Clements <glynn.clements@virgin.net>


Fri, Aug 3 2001 04:44:03    Mail sent by rshepard@appl-ecosys.com  
Return-Path <rshepard@appl-ecosys.com>
Delivered-To grass-bugs@mailman.intevation.de
Date Thu, 2 Aug 2001 19:43:41 -0700 (PDT)
From Rich Shepard <rshepard@appl-ecosys.com>
To Glynn Clements <glynn.clements@virgin.net>
Cc Request Tracker <grass-bugs@intevation.de>
Subject Re: [GRASS5] [bug #782] (grass) r.out.ascii/r.in.ascii
In-Reply-To <15210.1368.330812.433103@cerise.nosuchdomain.co.uk>
Message-ID <Pine.LNX.4.33.0108021941490.12724-100000@salmo.appl-ecosys.com>
MIME-Version 1.0
Content-Type TEXT/PLAIN; charset=US-ASCII
On Fri, 3 Aug 2001, Glynn Clements wrote:

> It appears that the author didn't quite understand the command-line
> parser. That argument has:
>
>     parm.output->gisprompt  = "old,cell,raster" ;
>
> which tells the parser that the "output" argument is the name of an
> existing raster map layer (it isn't; it's a filename).
>
> I'll commit a fix to this.

  Thanks, Glynn.

> r.in.ascii may have a bug, but it's not the same bug. Only "output"
> has a "gisprompt" value.

  OK, but it's the same visual effect to the user.

  While we're at it, when r.out.ascii runs it displays a percentage counter.
But, r.in.ascii does not. It would be nice to add this to the latter module
for consistency.

Gracias,

Rich

Dr. Richard B. Shepard, President

                       Applied Ecosystem Services, Inc. (TM)
            2404 SW 22nd Street | Troutdale, OR 97060-1247 | U.S.A.
 + 1 503-667-4517 (voice) | + 1 503-667-8863 (fax) | rshepard@appl-ecosys.com
Making environmentally-responsible mining happen.


Fri, Aug 3 2001 05:53:25    Mail sent by glynn.clements@virgin.net  
Return-Path <glynn.clements@virgin.net>
Delivered-To grass-bugs@mailman.intevation.de
From Glynn Clements <glynn.clements@virgin.net>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <15210.7872.334249.723517@cerise.nosuchdomain.co.uk>
Date Fri, 3 Aug 2001 04:47:12 +0100
To Rich Shepard <rshepard@appl-ecosys.com>
Cc Request Tracker <grass-bugs@intevation.de>
Subject Re: [GRASS5] [bug #782] (grass) r.out.ascii/r.in.ascii
In-Reply-To <Pine.LNX.4.33.0108021941490.12724-100000@salmo.appl-ecosys.com>
References <15210.1368.330812.433103@cerise.nosuchdomain.co.uk> <Pine.LNX.4.33.0108021941490.12724-100000@salmo.appl-ecosys.com>
X-Mailer VM 6.94 under 21.4 (patch 4) "Artificial Intelligence (candidate #1)" XEmacs Lucid
Rich Shepard wrote:

> > It appears that the author didn't quite understand the command-line
> > parser. That argument has:
> >
> >     parm.output->gisprompt  = "old,cell,raster" ;
> >
> > which tells the parser that the "output" argument is the name of an
> > existing raster map layer (it isn't; it's a filename).
> >
> > I'll commit a fix to this.
> 
>   Thanks, Glynn.
> 
> > r.in.ascii may have a bug, but it's not the same bug. Only "output"
> > has a "gisprompt" value.
> 
>   OK, but it's the same visual effect to the user.

I don't see it:

    $ r.in.ascii
    
    OPTION:   Ascii raster file to be imported
         key: input
    required: YES
    enter option > elevation.txt
    
    You have chosen:
      input=elevation.txt
    Is this correct? (y/n) [y] 
    
    OPTION:   Name for resultant raster map
         key: output
    required: YES
    
    Enter raster file name
    Enter 'list' for a list of existing raster files
    Hit RETURN to cancel request
    > elev
    <elev>
    
    OPTION:   Title for resultant raster map
         key: title
      format: "phrase"
    required: NO
    enter option > Elevation Map
    
    You have chosen:
      title=Elevation Map
    Is this correct? (y/n) [y] 
    
    OPTION:   Multiplier for ascii data
         key: mult
     default: 1.0 or read from header
    required: NO
    enter option > 
    
    OPTION:   String representing NULL value data cell
         key: nv
     default: * or read from header
    required: NO
    enter option > 
    
    FLAG: Set the following flag?
        integer values are imported?(y/n) [n] 
    
    FLAG: Set the following flag?
        floating point values are imported?(y/n) [n] 
    
    FLAG: Set the following flag?
        double floating point values are imported?(y/n) [n] 
    CREATING SUPPORT FILES FOR elev
    $ 


>   While we're at it, when r.out.ascii runs it displays a percentage counter.
> But, r.in.ascii does not. It would be nice to add this to the latter module
> for consistency.

OK, I'll do that.

-- 
Glynn Clements <glynn.clements@virgin.net>


Fri, Aug 3 2001 15:29:19    Mail sent by rshepard@appl-ecosys.com  
Return-Path <rshepard@appl-ecosys.com>
Delivered-To grass-bugs@mailman.intevation.de
Date Fri, 3 Aug 2001 06:29:00 -0700 (PDT)
From Rich Shepard <rshepard@appl-ecosys.com>
To <grass-bugs@intevation.de>
Subject Re: [GRASS5] [bug #782] (grass) r.out.ascii/r.in.ascii
In-Reply-To <15210.7872.334249.723517@cerise.nosuchdomain.co.uk>
Message-ID <Pine.LNX.4.33.0108030626020.14033-100000@salmo.appl-ecosys.com>
MIME-Version 1.0
Content-Type TEXT/PLAIN; charset=US-ASCII
On Fri, 3 Aug 2001, Glynn Clements wrote:

> I don't see it:

  Huh! It showed up here each time I ran it interactively. Of course,
neither r.out.ascii nor r.in.ascii display this behavior when both the input
and output files are specified on the command line.

  Oh, well. Perhaps it's just something here.

> >   While we're at it, when r.out.ascii runs it displays a percentage counter.
> > But, r.in.ascii does not. It would be nice to add this to the latter module
> > for consistency.
>
> OK, I'll do that.

  Thanks!

Rich

Dr. Richard B. Shepard, President

                       Applied Ecosystem Services, Inc. (TM)
            2404 SW 22nd Street | Troutdale, OR 97060-1247 | U.S.A.
 + 1 503-667-4517 (voice) | + 1 503-667-8863 (fax) | rshepard@appl-ecosys.com
Making environmentally-responsible mining happen.


Fri, Nov 9 2001 13:03:58    Status changed to resolved by alange  
Fri, Nov 9 2001 13:03:59    Owner changed to gclements by alange  
Fri, Nov 9 2001 13:03:58    Comments added by alange  
The mentioned problems are obviously solved. 
r.out.ascii and r.in.ascii have correct command line arguments, and the 
percentage output was implemented by Glynn. 

Andreas
Comment | Reply | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request