Details Ticket 5205


Comment | Reply | Take | Open


Serial Number 5205
Subject r.colors color=rules: few seconds delay between each warning
Area grass6
Queue grass
Requestors tutey@o2.pl
Owner none
Status resolved
Last User Contact Tue Oct 17 13:43:42 2006 (2 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Tue Oct 17 14:34:11 2006 (2 yr ago)
Created Thu Oct 12 17:28:46 2006 (2 yr ago)

Transaction History Ticket 5205


Thu, Oct 12 2006 17:28:46    Request created by msieczka  
Subject: r.colors color=rules: few seconds delay between each warning

If one makes a mistake in rules, resuming from each warning takes few sec.

eg.

$ r.colors map color=rules
Data range is 0 to 5
> [ENTER]
WARNING: bad color specification
[few seconds]
WARNING: rule is not added
[few seconds]

Maciek
Thu, Oct 12 2006 18:51:29    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17710.29323.351827.253687@cerise.gclements.plus.com>
Date Thu, 12 Oct 2006 17:51:23 +0100
To Request Tracker <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5205] (grass) r.colors color=rules: few seconds delay between each warning
In-Reply-To <20061012152846.1574B1005DA@lists.intevation.de>
References <20061012152846.1574B1005DA@lists.intevation.de>
X-Mailer VM 7.07 under 21.4 (patch 17) "Jumbo Shrimp" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Level
Request Tracker wrote:

> this bug's URL: http://intevation.de/rt/webrt?serial_num=5205
> -------------------------------------------------------------------------
> 
> Subject: r.colors color=rules: few seconds delay between each warning
> 
> If one makes a mistake in rules, resuming from each warning takes few sec.
> 
> eg.
> 
> $ r.colors map color=rules
> Data range is 0 to 5
> > [ENTER]
> WARNING: bad color specification
> [few seconds]
> WARNING: rule is not added
> [few seconds]

The delay is built into lib/gis/error.c; it should be removed, IMHO.

-- 
Glynn Clements <glynn@gclements.plus.com>


Fri, Oct 13 2006 00:17:52    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Fri, 13 Oct 2006 11:17:29 +1300
From Hamish <hamish_nospam@yahoo.com>
To Glynn Clements <glynn@gclements.plus.com>
Cc grass-bugs@intevation.de, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5205] (grass) r.colors color=rules: few seconds delay between each warning
Message-Id <20061013111729.53b3dce7.hamish_nospam@yahoo.com>
In-Reply-To <17710.29323.351827.253687@cerise.gclements.plus.com>
References <20061012152846.1574B1005DA@lists.intevation.de> <17710.29323.351827.253687@cerise.gclements.plus.com>
X-Mailer Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-2.3 tagged_above=-999 required=3 tests=[BAYES_00=-5, FORGED_YAHOO_RCVD=2.7]
X-Spam-Level
> > this bug's URL: http://intevation.de/rt/webrt?serial_num=5205
> > -------------------------------------------------------------------
> > 
> > Subject: r.colors color=rules: few seconds delay between each
> > warning
> > 
> > If one makes a mistake in rules, resuming from each warning takes
> > few sec.
> > 
> > eg.
> > 
> > $ r.colors map color=rules
> > Data range is 0 to 5
> > > [ENTER]
> > WARNING: bad color specification
> > [few seconds]
> > WARNING: rule is not added
> > [few seconds]
> 
> The delay is built into lib/gis/error.c; it should be removed, IMHO.


the delay is there for interactive modules which clear the screen; if
there is no delay there is no chance to see the warning before the
terminal blanks and know that something is wrong.

these modules call:
  G_sleep_on_error(1);


the default is:
  G_sleep_on_error(0);



the problem with r.colors is that raster/r.colors/main.c explicitly
calls G_sleep_on_error(1);


Hamish


Tue, Oct 17 2006 13:43:42    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17716.49642.556487.380874@cerise.gclements.plus.com>
Date Tue, 17 Oct 2006 12:43:38 +0100
To Hamish <hamish_nospam@yahoo.com>
Cc grass-bugs@intevation.de, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5205] (grass) r.colors color=rules: few seconds delay between each warning
In-Reply-To <20061013111729.53b3dce7.hamish_nospam@yahoo.com>
References <20061012152846.1574B1005DA@lists.intevation.de> <17710.29323.351827.253687@cerise.gclements.plus.com> <20061013111729.53b3dce7.hamish_nospam@yahoo.com>
X-Mailer VM 7.07 under 21.4 (patch 17) "Jumbo Shrimp" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Level
Hamish wrote:

> > > this bug's URL: http://intevation.de/rt/webrt?serial_num=5205
> > > -------------------------------------------------------------------
> > > 
> > > Subject: r.colors color=rules: few seconds delay between each
> > > warning
> > > 
> > > If one makes a mistake in rules, resuming from each warning takes
> > > few sec.
> > > 
> > > eg.
> > > 
> > > $ r.colors map color=rules
> > > Data range is 0 to 5
> > > > [ENTER]
> > > WARNING: bad color specification
> > > [few seconds]
> > > WARNING: rule is not added
> > > [few seconds]
> > 
> > The delay is built into lib/gis/error.c; it should be removed, IMHO.
> 
> the delay is there for interactive modules which clear the screen; if
> there is no delay there is no chance to see the warning before the
> terminal blanks and know that something is wrong.
> 
> these modules call:
>   G_sleep_on_error(1);
> 
> 
> the default is:
>   G_sleep_on_error(0);
> 
> the problem with r.colors is that raster/r.colors/main.c explicitly
> calls G_sleep_on_error(1);

I have removed the G_sleep_on_error() calls.

-- 
Glynn Clements <glynn@gclements.plus.com>


Tue, Oct 17 2006 14:34:11    Status changed to resolved by hbowman  
Comment | Reply | Take | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request