Fri, Mar 17 2006
03:34:11
|
|
Request created by guest
|
|
Subject: r.stats segfault
Platform: GNU/Linux/x86
grass binary for platform: Compiled from Sources
GRASS Version: grass-6.1.cvs_src_snapshot_2006_01_21
Running the following segfaults, r.stats should exit gracefully with an invalid
map list:
> r.stats -a input=
r.stats: Segmentation fault
>
Should be simple to fix :)
Cheers,Joel |
|
Sun, Mar 19 2006
06:36:00
|
|
Mail sent by hamish_nospam@yahoo.com
|
|
Return-Path |
<hamish_nospam@yahoo.com>
|
Delivered-To |
grass-bugs@lists.intevation.de
|
Date |
Sun, 19 Mar 2006 17:35:45 +1200
|
From |
Hamish <hamish_nospam@yahoo.com>
|
To |
Request Tracker <grass-bugs@intevation.de>
|
Cc |
grass5@grass.itc.it
|
Subject |
Re: [GRASS5] [bug #4178] (grass) r.stats segfault
|
Message-Id |
<20060319173545.39af670c.hamish_nospam@yahoo.com>
|
In-Reply-To |
<20060317023411.EF1FB10016A@lists.intevation.de>
|
References |
<20060317023411.EF1FB10016A@lists.intevation.de>
|
X-Mailer |
Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
|
X-Face |
M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
|
Mime-Version |
1.0
|
Content-Type |
text/plain; charset=US-ASCII
|
Content-Transfer-Encoding |
7bit
|
X-Spam-Status |
No, hits=-4.0 tagged_above=-999.0 required=3.0 tests=BAYES_00, FORGED_YAHOO_RCVD
|
X-Spam-Level |
|
> this bug's URL: http://intevation.de/rt/webrt?serial_num=4178
> ---------------------------------------------------------------------
>
> Subject: r.stats segfault
..
> Running the following segfaults, r.stats should exit gracefully with
> an invalid map list:
>
> > r.stats -a input=
> r.stats: Segmentation fault
> >
>
> Should be simple to fix :)
Done. More interesting is that this one works:
G> r.series in= out=foo meth=average
100%
(full of nan, but I use gcc -g..)
Maybe a general fix in lib/gis/parser.c is needed for ->answers?
Hamish
|
|
Sun, Mar 19 2006
06:44:21
|
|
Mail sent by hamish_nospam@yahoo.com
|
|
Return-Path |
<hamish_nospam@yahoo.com>
|
Delivered-To |
grass-bugs@lists.intevation.de
|
Date |
Sun, 19 Mar 2006 17:44:08 +1200
|
From |
Hamish <hamish_nospam@yahoo.com>
|
To |
Request Tracker <grass-bugs@intevation.de>
|
Cc |
grass5@grass.itc.it
|
Subject |
Re: [GRASS5] [bug #4178] (grass) r.stats segfault
|
Message-Id |
<20060319174408.2f0330b4.hamish_nospam@yahoo.com>
|
In-Reply-To |
<20060317023411.EF1FB10016A@lists.intevation.de>
|
References |
<20060317023411.EF1FB10016A@lists.intevation.de>
|
X-Mailer |
Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
|
X-Face |
M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
|
Mime-Version |
1.0
|
Content-Type |
text/plain; charset=US-ASCII
|
Content-Transfer-Encoding |
7bit
|
X-Spam-Status |
No, hits=-4.0 tagged_above=-999.0 required=3.0 tests=BAYES_00, FORGED_YAHOO_RCVD
|
X-Spam-Level |
|
> this bug's URL: http://intevation.de/rt/webrt?serial_num=4178
> ---------------------------------------------------------------------
>
> Subject: r.stats segfault
> Running the following segfaults, r.stats should exit gracefully with
> an invalid map list:
>
> > r.stats -a input=
> r.stats: Segmentation fault
These modules should be checked & fixed if needed before closing this bug:
r.buffer
r.cats
r.circle
r.compress
r.contour
r.cost
r.covar
r.cross
r.distance
r.drain
r.fill.dir
r.le
r.los
r.null
r.out.mpeg
r.out.vtk
r.profile
r.quant
r.random.surface
r.report
r.rescale
r.rescale.eq
r.to.rast3
r.transect
r.walk
r.water.outlet
r.what
wildfire/
base/
r3.mkdspf
r3.out.vtk
r3.to.rast
v.build
v.category
v.clean
v.distance
v.extract
v.extrude
v.in.dwg
v.in.ogr
v.label
v.mkgrid
v.net.iso
v.normal
v.overlay
v.patch
v.to.db
v.type
v.what
d.ask
d.barscale
d.geodesic
d.grid
d.legend
d.linegraph
d.nviz
d.rast
d.rhumbline
d.save
d.text
d.text.freetype
d.vect
d.vect.chart
d.what.rast
d.what.vect
d.zoom
g.mapsets
g.pnmcomp
g.region
manage/
if(! option->answer)
G_fatal_error(..);
doesn't get triggered,
if(option->answers[0] == NULL )
G_fatal_error(..);
does.
Hamish
|
|
Sun, Mar 26 2006
13:35:09
|
|
Mail sent by mneteler
|
|
https://intevation.de/rt/webrt?serial_num=4178
Would it be possible/easier to catch
if(option->answers[0] == NULL )
G_fatal_error(..);
in parser.c?
Markus |
|
Sun, Mar 26 2006
18:46:13
|
|
Mail sent by glynn@gclements.plus.com
|
|
Return-Path |
<glynn@gclements.plus.com>
|
Delivered-To |
grass-bugs@lists.intevation.de
|
From |
Glynn Clements <glynn@gclements.plus.com>
|
MIME-Version |
1.0
|
Content-Type |
text/plain; charset=us-ascii
|
Content-Transfer-Encoding |
7bit
|
Message-ID |
<17446.50509.321931.501549@cerise.gclements.plus.com>
|
Date |
Sun, 26 Mar 2006 17:46:05 +0100
|
To |
Markus Neteler via RT <grass-bugs@intevation.de>
|
Cc |
joel.pitt@gmail.com, grass5@grass.itc.it
|
Subject |
Re: [GRASS5] [bug #4178] (grass) r.stats segfault
|
In-Reply-To |
<20060326113509.BADB81006A5@lists.intevation.de>
|
References |
<20060326113509.BADB81006A5@lists.intevation.de>
|
X-Mailer |
VM 7.07 under 21.4 (patch 15) "Security Through Obscurity" XEmacs Lucid
|
X-Spam-Status |
No, hits=-4.9 tagged_above=-999.0 required=3.0 tests=BAYES_00
|
X-Spam-Level |
|
Markus Neteler via RT wrote:
> https://intevation.de/rt/webrt?serial_num=4178
>
> Would it be possible/easier to catch
> if(option->answers[0] == NULL )
> G_fatal_error(..);
> in parser.c?
It depends upon whether you want an option to be able to accept a list
of *zero* or more items, distinct from the option being omitted (note
that the parser won't allow a required option to be omitted).
If you want to allow that case, you can't put the check into parser.c;
modules with options which require at least one item must perform the
check themselves.
FWIW, there's no reason why r.series shouldn't be able to handle an
empty list of input maps; it already has to handle the case where all
of the input values for a given cell are null. In practice, an empty
list of input maps would produce an all-zero map for the count and sum
methods, and an all-null map for the other methods.
--
Glynn Clements <glynn@gclements.plus.com>
|
|