Details Ticket 3813


Comment | Reply | Take | Open


Serial Number 3813
Subject change ocurrences of malloc to G_malloc
Area grass6
Queue grass
Requestors kyngchaos@kyngchaos.com
Owner none
Status resolved
Last User Contact Fri Jan 20 00:43:16 2006 (3 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Fri Jan 20 00:43:19 2006 (3 yr ago)
Created Tue Nov 8 00:04:14 2005 (3 yr ago)

Transaction History Ticket 3813


Tue, Nov 8 2005 00:04:14    Request created by guest  
Subject: r.sim.water tries to include malloc.h on Mac OS X

Platform: Mac OSX
grass obtained from: Trento Italy site
grass binary for platform: Compiled from Sources
GRASS Version: 6.1 CVS

r.sim.water tries to include malloc.h on Mac OS X.  Mac OS X doesn't use malloc.h,
so r.sim.water fails 
to build.
Tue, Nov 8 2005 06:47:37    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Tue, 8 Nov 2005 18:47:12 +1300
From Hamish <hamish_nospam@yahoo.com>
To Request Tracker <grass-bugs@intevation.de>
Cc grass5@grass.itc.it
Subject Re: [GRASS5] [bug #3813] (grass) r.sim.water tries to include malloc.h on Mac OS X
Message-Id <20051108184712.76ecb551.hamish_nospam@yahoo.com>
In-Reply-To <20051107230414.E472D101FC9@lists.intevation.de>
References <20051107230414.E472D101FC9@lists.intevation.de>
X-Mailer Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Spam-Status No, hits=-4.0 tagged_above=-999.0 required=3.0 tests=BAYES_00, FORGED_YAHOO_RCVD
X-Spam-Level
> this bug's URL: http://intevation.de/rt/webrt?serial_num=3813
> ---------------------------------------------------------------------
> ----
> 
> Subject: r.sim.water tries to include malloc.h on Mac OS X
> 
> Platform: Mac OSX
> grass obtained from: Trento Italy site
> grass binary for platform: Compiled from Sources
> GRASS Version: 6.1 CVS
> 
> r.sim.water tries to include malloc.h on Mac OS X.  Mac OS X doesn't
> use malloc.h, so r.sim.water fails  to build.

pick one:
a) Try changing #include <malloc.h> to #include <stdlib.h>
in raster/simwe/r.sim.water/main.c

b) Try changing all occurrences of malloc() to G_malloc() and 
removing #include <malloc.h>



Stuff which should probably be using G_malloc() instead of malloc():

$ grep -rI malloc display/* raster/* general/* misc/* vector/* | \
     grep -v G_malloc | cut -f1 -d: | sort | uniq
display/d.rast.edit/menu.c
display/drivers/HTMLMAP/Graph_Set.c
display/drivers/HTMLMAP/Polygn_abs.c
display/drivers/HTMLMAP/Text.c
display/drivers/lib/Text3.c
raster/r.drain/main.c
raster/r.fill.dir/dopolys.c
raster/r.fill.dir/filldir.c
raster/r.fill.dir/ppupdate.c
raster/r.in.gdal/main.c
raster/r.in.gridatb/file_io.c
raster/r.le/r.le.setup/setup.c
raster/r.mapcalc/evaluate.c
raster/r.mapcalc/expression.c
raster/r.mapcalc/lex.yy.c
raster/r.mapcalc/y.tab.c
raster/r.out.mpeg/main.c
raster/r.out.mpeg/write.c
raster/r.out.tiff/r.out.tiff.c
raster/r.param.scale/nrutil.c
raster/r.resamp.rst/main.c
raster/r.sun/main.c
raster/r.sunmask/main.c
raster/r.surf.contour/flag_create.c
raster/r.terraflow/IOStream/lib/src/mm.cc
raster/r.terraflow/filldepr.cc
raster/r.terraflow/main.cc
raster/r.terraflow/stats.cc
raster/r.to.vect/global.h
raster/r.to.vect/lines.c
raster/r.to.vect/util.c
raster/r.topidx/file_io.c
raster/r.topmodel/file_io.c
raster/r.topmodel/topmodel.c
raster/simwe/r.sim.sediment/main.c
raster/simwe/r.sim.water/main.c
raster/simwe/simlib/input.c
raster/wildfire/r.spread/spread.c
vector/v.convert/read.c
vector/v.in.dwg/entity.c
vector/v.in.dwg/main.c
vector/v.mapcalc/list.c
vector/v.mapcalc/yylex.c
vector/v.surf.rst/main.c
vector/v.surf.rst/up_rst.diff
vector/v.vol.rst/dataoct.c
vector/v.vol.rst/main.c
vector/v.vol.rst/oct.c
vector/v.vol.rst/user1.c
vector/v.vol.rst/user2.c
vector/v.vol.rst/user3.c
vector/v.voronoi/sw_memory.c
vector/v.voronoi/vo_main.c

?


Hamish


Tue, Nov 8 2005 16:10:51    Mail sent by kyngchaos@kyngchaos.com  
Return-Path <kyngchaos@kyngchaos.com>
Delivered-To grass-bugs@lists.intevation.de
X-IronPort-AV i="3.97,304,1125892800"; d="scan'208"; a="402643497:sNHT17131684"
In-Reply-To <20051108184712.76ecb551.hamish_nospam@yahoo.com>
References <20051107230414.E472D101FC9@lists.intevation.de> <20051108184712.76ecb551.hamish_nospam@yahoo.com>
Mime-Version 1.0 (Apple Message framework v746.2)
Content-Type text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id <14A32268-36A6-4563-86F9-D1E4A569C7AB@kyngchaos.com>
Cc Hamish <hamish@yahoo.com>
Content-Transfer-Encoding 7bit
From William Kyngesburye <kyngchaos@kyngchaos.com>
Subject Re: [GRASS5] [bug #3813] (grass) r.sim.water tries to include malloc.h on Mac OS X
Date Tue, 8 Nov 2005 09:10:37 -0600
To Request Tracker <grass-bugs@intevation.de>
X-Mailer Apple Mail (2.746.2)
X-Spam-Status No, hits=-4.9 tagged_above=-999.0 required=3.0 tests=BAYES_00
X-Spam-Level
> pick one:
> a) Try changing #include <malloc.h> to #include <stdlib.h>
> in raster/simwe/r.sim.water/main.c
>
This works.  r.sim.water already includes stdlib.h, so it's simply a  
matter of removing malloc.h.

> b) Try changing all occurrences of malloc() to G_malloc() and
> removing #include <malloc.h>
>
Can G_malloc simply be substituted for malloc, or are there some  
other code changes needed?  This would probably be the better way  
instead of figuring out a platform check on whether to include  
malloc.h or not.

>
> Stuff which should probably be using G_malloc() instead of malloc():

That looks like quite a cleanup job for someone.


Thu, Nov 17 2005 06:42:39    Subject changed to change ocurrences of malloc to G_malloc by dcalvelo  
Fri, Jan 20 2006 00:43:16    Mail sent by mneteler  
Hi,

we have fixed all the mallocs/allocs/calloc/reallocs/frees.
Assuming that the problem is solved, I'll close the report.

Markus
Fri, Jan 20 2006 00:43:19    Status changed to resolved by mneteler  
Comment | Reply | Take | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request