Details Ticket 3469


Comment | Reply | Take | Open


Serial Number 3469
Subject about i.class
Area grass6
Queue grass
Requestors vananh@sci.osaka-cu.ac.jp
Owner none
Status resolved
Last User Contact Wed Aug 31 20:43:53 2005 (3 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Tue Jun 19 08:08:27 2007 (1 yr ago)
Created Sun Jul 31 09:46:30 2005 (3 yr ago)

Transaction History Ticket 3469


Sun, Jul 31 2005 09:46:30    Request created by guest  
Subject: about i.class

Platform: GNU/Linux/i386
grass obtained from: CVS
grass binary for platform: Compiled from Sources

 I am working with GRASS61, I try with i.class for supervised classification.
After drawing the region on image I click to the Analyze region Menu, I get this
error message WARNING:PREPARE_SIGNATURE: DATA ERROR (CLICK MOUSE TO CONTINUE).
It seem that all the regions that I chose before now disappear. I try again with
GRASS57, the result is also the same. Can you solve this problem for me? Thank
you very much,
Best regards,
Tran Van Anh
Mon, Aug 8 2005 15:29:03    Mail sent by neteler@itc.it  
Return-Path <neteler@itc.it>
Delivered-To grass-bugs@lists.intevation.de
Date Mon, 8 Aug 2005 15:28:57 +0200
From Markus Neteler <neteler@itc.it>
To Brad Douglas <rez@touchofmadness.com>
Cc GRASS dev list <grass5@grass.itc.it>, grass-bugs@intevation.de
Subject Re: [GRASS5] [bug #3469] (grass) about i.class
Message-ID <20050808132857.GH3541@thuille.itc.it>
Mail-Followup-To Brad Douglas <rez@touchofmadness.com>, GRASS dev list <grass5@grass.itc.it>, grass-bugs@intevation.de
References <20050731074630.9547A1005A2@lists.intevation.de> <1123474741.12324.94.camel@albedo>
Mime-Version 1.0
Content-Type multipart/mixed; boundary="IiVenqGWf+H9Y6IX"
Content-Disposition inline
In-Reply-To <1123474741.12324.94.camel@albedo>
User-Agent Mutt/1.4.1i
X-PGP-Key http://www.gdf-hannover.de/neteler/markus_gpgkey.asc
X-Spam-Status No, hits=-4.9 tagged_above=-999.0 required=3.0 tests=BAYES_00
X-Spam-Level
--IiVenqGWf+H9Y6IX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Aug 07, 2005 at 09:19:01PM -0700, Brad Douglas wrote:
> On Sun, 2005-07-31 at 09:46 +0200, Request Tracker wrote:
> > this bug's URL: http://intevation.de/rt/webrt?serial_num=3469
> > -------------------------------------------------------------------------
> > 
> > Subject: about i.class
> > 
> > Platform: GNU/Linux/i386
> > grass obtained from: CVS
> > grass binary for platform: Compiled from Sources
> > 
> >  I am working with GRASS61, I try with i.class for supervised classification.
After drawing the region on image I click to the Analyze region Menu, I get this
error message WARNING:PREPARE_SIGNATURE: DATA ERROR (CLICK MOUSE TO CONTINUE).
It seem that all the regions that I chose before now disappear. I try again with
GRASS57, the result is also the same. Can you solve this problem for me? Thank
you very much,
> > Best regards,
> > Tran Van Anh
> 
> I traced this back to INAME_LEN being changed from 30 to 256 in
> include/imagery.h.
> 
> This makes lib/vask/V_ques.c: V_ques() bomb out starting at line:
> 
> if ((length <= 0) || ((length + col) > 80)) ...
> 
> where the variable 'length' is passed in as INAME_LEN.
> 
> The program keeps running until it dies with a floating point exception.

Brad,

the bug discovered by you is probably a new bug.

Miss Van Anh reports that GRASS57 also failed.

For testing, the LANDSAT-7 scene prepared for the Spearfish location
 http://mpa.itc.it/grasstutor/data_menu2nd.phtml
 -> p033r029_20000712_NAD27_small.tar.gz
may be used.

for i in p033*.tif ; do 
    NAME=`echo $i | cut -d'_' -f4`
    r.in.gdal $i out=$NAME
done

i.group gr=lsat subgroup=lsat in=nn10,nn20,nn30,nn40,nn50,nn70
i.class

i.class
V_ask error: Length out of bounds in call to V_ques
V_ask error: Length out of bounds in call to V_ques

Now I see the new bug, coming from
lib/imagery/
vask_group.c:   V_ques (group, 's', line++, 10, INAME_LEN);

Attached patch cures *this* problem. Apply to CVS?

Then I made a quick test using i.class.
For me the reported error "prepare_signature: data error." doesn't happen.

Markus


--IiVenqGWf+H9Y6IX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="vask_group.diff"

Index: lib/imagery/vask_group.c
===================================================================
RCS file: /grassrepository/grass6/lib/imagery/vask_group.c,v
retrieving revision 2.0
diff -u -r2.0 vask_group.c
--- lib/imagery/vask_group.c	9 Nov 2004 12:28:44 -0000	2.0
+++ lib/imagery/vask_group.c	8 Aug 2005 13:27:44 -0000
@@ -5,6 +5,8 @@
 #define OLD 1
 #define NEW 2
 
+#define MYINAME_LEN 30 /* this contradicts long file name support */
+
 static int ask ( char **, char *,char *, int , int, char *);
 
 int I_vask_group_new (
@@ -86,17 +88,17 @@
     if (both)
     {
 	V_line (line, "GROUP:                                     (list will show available
groups)");
-	V_ques (group, 's', line++, 10, INAME_LEN);
+	V_ques (group, 's', line++, 10, MYINAME_LEN);
     }
     else
     {
 	V_line (line, "GROUP:");
-	V_const (group, 's', line++, 10, INAME_LEN);
+	V_const (group, 's', line++, 10, MYINAME_LEN);
     }
     if (subgroup != NULL)
     {
 	V_line (line, "SUBGROUP:                                  (list will show available
subgroups)");
-	V_ques (subgroup, 's', line++, 10, INAME_LEN);
+	V_ques (subgroup, 's', line++, 10, MYINAME_LEN);
     }
 
 

--IiVenqGWf+H9Y6IX--


Tue, Aug 16 2005 23:09:54    Mail sent by mneteler  
Hi,

I have applied the patch in a modified way. Now i.class
is operable again in 6.1.

However, the bug reported by Miss Van Anh I cannot
reproduce. Anh, do you use the "Complete region" function
after digitizing an area?

Markus
Wed, Aug 17 2005 03:09:57    Mail sent by vananh@sci.osaka-cu.ac.jp  
Return-Path <vananh@sci.osaka-cu.ac.jp>
Delivered-To grass-bugs@lists.intevation.de
Message-ID <000701c5a2c8$59ef2190$717bc1a0@ANH>
From "Tran Van Anh" <vananh@sci.osaka-cu.ac.jp>
To "Markus Neteler via RT" <grass-bugs@intevation.de>
References <20050816210954.2ACE61006DF@lists.intevation.de>
Subject Re: [bug #3469] (grass) about i.class
Date Wed, 17 Aug 2005 10:09:38 +0900
MIME-Version 1.0
Content-Type text/plain; format=flowed; charset="iso-2022-jp"; reply-type=original
Content-Transfer-Encoding 7bit
X-Priority 3
X-MSMail-Priority Normal
X-Mailer Microsoft Outlook Express 6.00.2900.2180
X-MimeOLE Produced By Microsoft MimeOLE V6.00.2900.2180
X-Spam-Status No, hits=-0.0 tagged_above=-999.0 required=3.0 tests=BAYES_44
X-Spam-Level
Hello Markus,
Thank for your news, I usually do "Complete region"  function after 
digitizing. Is there any problem with this function?
>From Anh
----- Original Message ----- 
From: "Markus Neteler via RT" <grass-bugs@intevation.de>
To: <vananh@sci.osaka-cu.ac.jp>
Sent: Wednesday, August 17, 2005 6:09 AM
Subject: [bug #3469] (grass) about i.class


> Hi,
>
> I have applied the patch in a modified way. Now i.class
> is operable again in 6.1.
>
> However, the bug reported by Miss Van Anh I cannot
> reproduce. Anh, do you use the "Complete region" function
> after digitizing an area?
>
> Markus
>
> -------------------------------------------- Managed by Request Tracker
>
> 


Wed, Aug 31 2005 20:43:53    Mail sent by mneteler  
Dear Anh,

the problem is that I cannot reproduce it...
Does anyone else have the problem? Or, can you reproduce it
in Spearfish?

Best regards

 markus
Fri, Sep 2 2005 08:11:29    Mail sent by vananh@sci.osaka-cu.ac.jp  
Return-Path <vananh@sci.osaka-cu.ac.jp>
Delivered-To grass-bugs@lists.intevation.de
Message-ID <000501c5af85$1eb50c60$717bc1a0@ANH>
From "Tran Van Anh" <vananh@sci.osaka-cu.ac.jp>
To "Markus Neteler via RT" <grass-bugs@intevation.de>
References <20050831184353.2212D1005AD@lists.intevation.de>
Subject Re: [bug #3469] (grass) about i.class
Date Fri, 2 Sep 2005 15:11:07 +0900
MIME-Version 1.0
Content-Type text/plain; format=flowed; charset="iso-2022-jp"; reply-type=original
Content-Transfer-Encoding 7bit
X-Priority 3
X-MSMail-Priority Normal
X-Mailer Microsoft Outlook Express 6.00.2900.2180
X-MimeOLE Produced By Microsoft MimeOLE V6.00.2900.2180
X-Spam-Status No, hits=-0.9 tagged_above=-999.0 required=3.0 tests=BAYES_10
X-Spam-Level
Dear Markus,
I asked one colleague in my lab check with his computer that has just 
installed Mandriva and grass60 source. i.class is working in it without any 
error. maybe the problem from the system. Thank you very much
Best regards,
Anh
----- Original Message ----- 
From: "Markus Neteler via RT" <grass-bugs@intevation.de>
To: <vananh@sci.osaka-cu.ac.jp>
Sent: Thursday, September 01, 2005 3:43 AM
Subject: [bug #3469] (grass) about i.class


> Dear Anh,
>
> the problem is that I cannot reproduce it...
> Does anyone else have the problem? Or, can you reproduce it
> in Spearfish?
>
> Best regards
>
> markus
>
> -------------------------------------------- Managed by Request Tracker
>
> 


Tue, Jun 19 2007 08:08:27    Status changed to resolved by hbowman  
Comment | Reply | Take | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request