Details Ticket 5098


Comment | Reply | Take | Open


Serial Number 5098
Subject gis.m; tcltk error when zooming to map with name which exists in more than one mapset
Area grass6
Queue grass
Requestors mlennert@club.worldonline.be
Owner none
Status resolved
Last User Contact Fri Sep 15 09:03:27 2006 (2 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Sat Nov 4 16:54:13 2006 (2 yr ago)
Created Mon Sep 4 18:13:15 2006 (2 yr ago)

Transaction History Ticket 5098


Mon, Sep 4 2006 18:13:15    Request created by guest  
Subject: gis.m; tcltk error when zooming to map with name which exists in more
than one mapset

Platform: GNU/Linux/x86
grass obtained from: CVS
grass binary for platform: Compiled from Sources
GRASS Version: cvs_head_20060904

When there are two maps with the same name in more than one of the accessible
mapsets, then gis.m throws below tcltk error when I try to "zoom to selected
map". To reproduce in spearfish, just copy any map from the PERMANENT mapset
to the user1 mapset using the same name and then display it and zoom to it. If
I enter @mapsetname (i.e. @user1) after the map name zooming to the map works.
It is probably just a question of catching the WARNING message and ignoring it,
or of adding the @mapsetname automatically (default to current mapset if not
set otherwise).

BTW, I find the warning message a bit weird: when I display roads from user1
I get the message "WARNING: 'vector/roads' was found in more mapsets (also found
in user1)". In my understanding this should read "... (also found in PERMANENT)...
WARNING: 'vector/roads' was found in more mapsets (also found in user1).
WARNING: 'vector/roads' was found in more mapsets (also found in user1).
    while executing
"close $input"
    (procedure "MapCanvas::zoom_gregion" line 11)
    invoked from within
"MapCanvas::zoom_gregion $mon [list "vect=$map"]"
    (procedure "MapCanvas::zoom_map" line 48)
    invoked from within
"MapCanvas::zoom_map $mon"
    invoked from within
".mapcan(1).mf.topf.tb0.mapzoom.zm invoke active"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 [list $w invoke active]"
    (procedure "tk::MenuInvoke" line 50)
    invoked from within
"tk::MenuInvoke .mapcan(1).mf.topf.tb0.mapzoom.zm 1"
    (command bound to event)

Moritz
Mon, Sep 4 2006 19:42:10    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17660.25959.874889.172137@cerise.gclements.plus.com>
Date Mon, 4 Sep 2006 18:41:59 +0100
To Request Tracker <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to map with name which exists in more than one mapset
In-Reply-To <20060904161315.D81B31005C5@lists.intevation.de>
References <20060904161315.D81B31005C5@lists.intevation.de>
X-Mailer VM 7.07 under 21.4 (patch 15) "Security Through Obscurity" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Level
Request Tracker wrote:

> this bug's URL: http://intevation.de/rt/webrt?serial_num=5098
> -------------------------------------------------------------------------
> 
> Subject: gis.m; tcltk error when zooming to map with name which exists in more
than one mapset
> 
> Platform: GNU/Linux/x86
> grass obtained from: CVS
> grass binary for platform: Compiled from Sources
> GRASS Version: cvs_head_20060904
> 
> When there are two maps with the same name in more than one of the
> accessible mapsets, then gis.m throws below tcltk error when I try to
> "zoom to selected map". To reproduce in spearfish, just copy any map
> from the PERMANENT mapset to the user1 mapset using the same name and
> then display it and zoom to it. If I enter @mapsetname (i.e. @user1)
> after the map name zooming to the map works.
> 
> It is probably just a question of catching the WARNING message and
> ignoring it, or of adding the @mapsetname automatically (default to
> current mapset if not set otherwise).

Whenever any Tcl/Tk code runs a GRASS command, it needs to use
"2>@stdout". Tcl treats it as an error if anything is written to
stderr.

Genuine errors will still be detected by a non-zero exit code.

-- 
Glynn Clements <glynn@gclements.plus.com>


Mon, Sep 4 2006 20:32:57    Mail sent by michael.barton@asu.edu  
Return-Path <michael.barton@asu.edu>
Delivered-To grass-bugs@lists.intevation.de
User-Agent Microsoft-Entourage/11.2.5.060620
Date Mon, 04 Sep 2006 11:31:59 -0700
Subject Re: [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to map with name which exists in more than one mapset
From Michael Barton <michael.barton@asu.edu>
To Paolo Cavallini via RT <grass-bugs@intevation.de>, <grass-dev@grass.itc.it>
Cc Maciek Sieczka <werchowyna@epf.pl>, Markus Neteler <neteler@itc.it>
Message-ID <C121BF2F.DFFB%michael.barton@asu.edu>
Thread-Topic [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to map with name which exists in more than one mapset
Thread-Index AcbQUGgnprx33jxDEdu/mQAKlXAweg==
In-Reply-To <20060904161315.D81B31005C5@lists.intevation.de>
Mime-version 1.0
Content-type text/plain; charset="US-ASCII"
Content-transfer-encoding 7bit
X-Virus-Scanned by amavisd-new
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-3.752 tagged_above=-999 required=3 tests=[BAYES_00=-5, RCVD_NUMERIC_HELO=1.248]
X-Spam-Level
Maceij has reported this too.

I'm trying to do a bunch of comprehensive bug fixes (they never seem to end)
to gism. I think I've fixed this one.

I was finally able to reproduce a strange one that he also reported about
zooming when 2 or more map display are visible. Reproducing it on my Mac was
difficult, but fixing this was much harder. But I think I got it.

This has involved changing most of the many global variables floating around
to ones tied to local name spaces, and replacing other variables with arrays
indexed by active display monitor.

I hope to get this committed either tomorrow or Wednesday.

Hopefully, this will make the whole system more robust.

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton



> From: Request Tracker <grass-bugs@intevation.de>
> Reply-To: Request Tracker <grass-bugs@intevation.de>
> Date: Mon,  4 Sep 2006 18:13:15 +0200 (CEST)
> To: <grass-dev@grass.itc.it>
> Subject: [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to
> map with name which exists in more than one mapset
> 
> this bug's URL: http://intevation.de/rt/webrt?serial_num=5098
> -------------------------------------------------------------------------
> 
> Subject: gis.m; tcltk error when zooming to map with name which exists in more
> than one mapset
> 
> Platform: GNU/Linux/x86
> grass obtained from: CVS
> grass binary for platform: Compiled from Sources
> GRASS Version: cvs_head_20060904
> 
> When there are two maps with the same name in more than one of the accessible
> mapsets, then gis.m throws below tcltk error when I try to "zoom to selected
> map". To reproduce in spearfish, just copy any map from the PERMANENT mapset
> to the user1 mapset using the same name and then display it and zoom to it.
If
> I enter @mapsetname (i.e. @user1) after the map name zooming to the map works.
> 
> It is probably just a question of catching the WARNING message and ignoring
> it, or of adding the @mapsetname automatically (default to current mapset if
> not set otherwise).
> 
> BTW, I find the warning message a bit weird: when I display roads from user1
I
> get the message "WARNING: 'vector/roads' was found in more mapsets (also found
> in user1)". In my understanding this should read "... (also found in
> PERMANENT)...
> 
> WARNING: 'vector/roads' was found in more mapsets (also found in user1).
> WARNING: 'vector/roads' was found in more mapsets (also found in user1).
>     while executing
> "close $input"
>     (procedure "MapCanvas::zoom_gregion" line 11)
>     invoked from within
> "MapCanvas::zoom_gregion $mon [list "vect=$map"]"
>     (procedure "MapCanvas::zoom_map" line 48)
>     invoked from within
> "MapCanvas::zoom_map $mon"
>     invoked from within
> ".mapcan(1).mf.topf.tb0.mapzoom.zm invoke active"
>     ("uplevel" body line 1)
>     invoked from within
> "uplevel #0 [list $w invoke active]"
>     (procedure "tk::MenuInvoke" line 50)
>     invoked from within
> "tk::MenuInvoke .mapcan(1).mf.topf.tb0.mapzoom.zm 1"
>     (command bound to event)
> 
> Moritz
> 
> -------------------------------------------- Managed by Request Tracker
> 
> 


Mon, Sep 4 2006 20:44:09    Mail sent by michael.barton@asu.edu  
Return-Path <michael.barton@asu.edu>
Delivered-To grass-bugs@lists.intevation.de
User-Agent Microsoft-Entourage/11.2.5.060620
Date Mon, 04 Sep 2006 11:38:46 -0700
Subject Re: [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to map with name which exists in more than one mapset
From Michael Barton <michael.barton@asu.edu>
To Paolo Cavallini via RT <grass-bugs@intevation.de>, <grass-dev@grass.itc.it>, Moritz Lennert <mlennert@club.worldonline.be>
Cc Maciek Sieczka <werchowyna@epf.pl>, Markus Neteler <neteler@itc.it>
Message-ID <C121C0C6.DFFD%michael.barton@asu.edu>
Thread-Topic [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to map with name which exists in more than one mapset
Thread-Index AcbQUVq+mY9lZDxEEdu/mQAKlXAweg==
In-Reply-To <20060904161315.D81B31005C5@lists.intevation.de>
Mime-version 1.0
Content-type text/plain; charset="US-ASCII"
Content-transfer-encoding 7bit
X-Virus-Scanned by amavisd-new
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-3.752 tagged_above=-999 required=3 tests=[BAYES_00=-5, RCVD_NUMERIC_HELO=1.248]
X-Spam-Level
I'm doing a bunch of fixes (they never seem to end do they?) prompted by a
weird bug report by Maciej about odd behavior zooming between two map
displays. This was tricky to reproduce on my Mac and much more difficult to
fix. I think I got it, but it involved changing most of the many global
variables floating around to variables within local namespaces, and indexing
more variables by active display monitor.

I also found and dispatched a few other hidden bugs and bugs waiting to
happen.

I've fixed this one too I hope. Maciej and other have reported it before,
but it has been intermittent on my Mac--making a fix difficult.

This cleanup should make the whole application more robust.

I want to commit all this tomorrow or on Wednesday (depending on my schedule
and access to the cvs tomorrow).

Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University

phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton



> From: Request Tracker <grass-bugs@intevation.de>
> Reply-To: Request Tracker <grass-bugs@intevation.de>
> Date: Mon,  4 Sep 2006 18:13:15 +0200 (CEST)
> To: <grass-dev@grass.itc.it>
> Subject: [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to
> map with name which exists in more than one mapset
> 
> BTW, I find the warning message a bit weird: when I display roads from user1
I
> get the message "WARNING: 'vector/roads' was found in more mapsets (also found
> in user1)". In my understanding this should read "... (also found in
> PERMANENT)...


Sun, Sep 10 2006 23:43:05    Mail sent by msieczka  
Moritz,

This bug is fixed for me using current CVS. Closing it. If you still can
reproduce the bug, please reply to this message will wil re-open your report.
Thanks,
Maciek
Sun, Sep 10 2006 23:43:10    Status changed to resolved by msieczka  
Mon, Sep 11 2006 09:18:44    Mail sent by mlennert@club.worldonline.be  
Return-Path <mlennert@club.worldonline.be>
Delivered-To grass-bugs@lists.intevation.de
Message-ID <45050DF4.20108@club.worldonline.be>
Date Mon, 11 Sep 2006 09:19:16 +0200
From Moritz Lennert <mlennert@club.worldonline.be>
User-Agent Thunderbird 1.5.0.5 (X11/20060812)
MIME-Version 1.0
To Maciek Sieczka via RT <grass-bugs@intevation.de>
Subject Re: [bug #5098] (grass) gis.m; tcltk error when zooming to map with name which exists in more than one mapset
References <20060910214305.2ADBD1005C5@lists.intevation.de>
In-Reply-To <20060910214305.2ADBD1005C5@lists.intevation.de>
Content-Type text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Level
Maciek Sieczka via RT wrote:
> Moritz,
> 
> 
> 
> This bug is fixed for me using current CVS. Closing it. If you still can
> 
> reproduce the bug, please reply to this message will wil re-open your report.
Fixed more me, too.

Thanks,
Moritz


Mon, Sep 11 2006 09:18:44    Status changed to open by _rt_system  
Fri, Sep 15 2006 06:29:42    Mail sent by grass4u@gmail.com  
Return-Path <grass4u@gmail.com>
Delivered-To grass-bugs@lists.intevation.de
DomainKey-Signature a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=Qi1rytk3I7qs3oZ4RpKcBxET7DrhT9Qsq0cR+GN3SmmY0s7Y6SQbF/RIFNN93IyqdWrHjlMGorDud6A5YuwxGlcZvWIe6O8do19O05oehem3QYmC9YReAIYzNuL+5ynPxVOwOoRa5NVHcvEy4aa371WvRiQBB34pEXGAgLpm7YE=
Date Thu, 14 Sep 2006 23:28:49 -0500
From Huidae Cho <grass4u@gmail.com>
To Glynn Clements <glynn@gclements.plus.com>
Cc Request Tracker <grass-bugs@intevation.de>, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to map with name which exists in more than one mapset
Message-ID <20060915042849.GA31362@localhost.tamu.edu>
References <20060904161315.D81B31005C5@lists.intevation.de> <17660.25959.874889.172137@cerise.gclements.plus.com>
Mime-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
In-Reply-To <17660.25959.874889.172137@cerise.gclements.plus.com>
User-Agent mutt-ng/devel (FreeBSD)
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-4.933 tagged_above=-999 required=3 tests=[BAYES_00=-5, RCVD_BY_IP=0.067]
X-Spam-Level
On Mon, Sep 04, 2006 at 06:41:59PM +0100, Glynn Clements wrote:
> 
> Request Tracker wrote:
> 
> > this bug's URL: http://intevation.de/rt/webrt?serial_num=5098
> > -------------------------------------------------------------------------
> > 
> > Subject: gis.m; tcltk error when zooming to map with name which exists in
more than one mapset
> > 
> > Platform: GNU/Linux/x86
> > grass obtained from: CVS
> > grass binary for platform: Compiled from Sources
> > GRASS Version: cvs_head_20060904
> > 
> > When there are two maps with the same name in more than one of the
> > accessible mapsets, then gis.m throws below tcltk error when I try to
> > "zoom to selected map". To reproduce in spearfish, just copy any map
> > from the PERMANENT mapset to the user1 mapset using the same name and
> > then display it and zoom to it. If I enter @mapsetname (i.e. @user1)
> > after the map name zooming to the map works.
> > 
> > It is probably just a question of catching the WARNING message and
> > ignoring it, or of adding the @mapsetname automatically (default to
> > current mapset if not set otherwise).
> 
> Whenever any Tcl/Tk code runs a GRASS command, it needs to use
> "2>@stdout". Tcl treats it as an error if anything is written to
> stderr.
> 
> Genuine errors will still be detected by a non-zero exit code.
> 

Are all GRASS commands called by grass-xterm-wrapper and grass-run.sh?
If so, can we just move this redirection to grass-xterm-wrapper so that
Windows users are happy?  $mingw test for separate redirection is ugly.

Huidae


Fri, Sep 15 2006 09:03:27    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17674.20532.77379.384601@cerise.gclements.plus.com>
Date Fri, 15 Sep 2006 08:03:16 +0100
To Huidae Cho <grass4u@gmail.com>
Cc Request Tracker <grass-bugs@intevation.de>, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #5098] (grass) gis.m; tcltk error when zooming to map with name which exists in more than one mapset
In-Reply-To <20060915042849.GA31362@localhost.tamu.edu>
References <20060904161315.D81B31005C5@lists.intevation.de> <17660.25959.874889.172137@cerise.gclements.plus.com> <20060915042849.GA31362@localhost.tamu.edu>
X-Mailer VM 7.07 under 21.4 (patch 15) "Security Through Obscurity" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Level
Huidae Cho wrote:

> > > this bug's URL: http://intevation.de/rt/webrt?serial_num=5098
> > > -------------------------------------------------------------------------
> > > 
> > > Subject: gis.m; tcltk error when zooming to map with name which exists
in more than one mapset
> > > 
> > > Platform: GNU/Linux/x86
> > > grass obtained from: CVS
> > > grass binary for platform: Compiled from Sources
> > > GRASS Version: cvs_head_20060904
> > > 
> > > When there are two maps with the same name in more than one of the
> > > accessible mapsets, then gis.m throws below tcltk error when I try to
> > > "zoom to selected map". To reproduce in spearfish, just copy any map
> > > from the PERMANENT mapset to the user1 mapset using the same name and
> > > then display it and zoom to it. If I enter @mapsetname (i.e. @user1)
> > > after the map name zooming to the map works.
> > > 
> > > It is probably just a question of catching the WARNING message and
> > > ignoring it, or of adding the @mapsetname automatically (default to
> > > current mapset if not set otherwise).
> > 
> > Whenever any Tcl/Tk code runs a GRASS command, it needs to use
> > "2>@stdout". Tcl treats it as an error if anything is written to
> > stderr.
> > 
> > Genuine errors will still be detected by a non-zero exit code.
> 
> Are all GRASS commands called by grass-xterm-wrapper and grass-run.sh?

No. Those are only used for commands which need to be run in an xterm
because they interact with the user via a terminal. They aren't used
for modules which can operate without user interaction (i.e. the
majority of GRASS modules).

-- 
Glynn Clements <glynn@gclements.plus.com>


Sat, Nov 4 2006 16:54:13    Status changed to resolved by msieczka  
Comment | Reply | Take | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request