Details Ticket 4983


Comment | Reply | Take | Open


Serial Number 4983
Subject r.blend: the output name check doesn't work
Area grass6
Queue grass
Requestors tutey@o2.pl
Owner none
Status resolved
Last User Contact Tue Aug 8 19:44:15 2006 (2 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Tue Aug 8 19:44:48 2006 (2 yr ago)
Created Tue Aug 8 09:20:19 2006 (2 yr ago)

Transaction History Ticket 4983


Tue, Aug 8 2006 09:20:19    Request created by guest  
Subject: r.blend: the output name check is to strict

Platform: GNU/Linux/x86
grass obtained from: CVS
grass binary for platform: Compiled from Sources
GRASS Version: 2006.08.02

If the output *base* name is identical to input name, an error is issued:

   r.blend first=map1 second=map2 output=map1

   Error: option <output>: <map1> exists.

This is *wrong* - r.blend *won't* be overwriting <map1>, it will be *creating*
map1.r map1.b and map1.g, OTW, using the <map1> as a *base* name only ("Base
name for red, green, & blue output maps containing the blend", like manuall says).
Maciek
Tue, Aug 8 2006 09:31:19    Mail sent by msieczka  
Moreover, r.blend ignores --ovewrite flag:

   $ g.list rast | grep map1_blend

     map1_blend.b            map1_blend.g
     map1_blend.r

   $ r.blend --o first=map1 second=map2 output=map1_blend
     Raster map <map1_blend.r> already exists.

*I know* it *exists* - that's why I'm using --o switch; but it's ignored for
some reason.

I'm changing the subject to 'r.blend: the output name check doesn't work'.

Maciek
Tue, Aug 8 2006 09:31:26    Subject changed to r.blend: the output name check doesn't work by msieczka  
Tue, Aug 8 2006 19:18:50    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17624.51059.716209.350444@cerise.gclements.plus.com>
Date Tue, 8 Aug 2006 18:18:43 +0100
To Maciek Sieczka via RT <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #4983] (grass) r.blend: the output name check is to strict
In-Reply-To <20060808073119.48F74100161@lists.intevation.de>
References <20060808073119.48F74100161@lists.intevation.de>
X-Mailer VM 7.07 under 21.4 (patch 15) "Security Through Obscurity" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-3.436 tagged_above=-999 required=3 tests=[AWL=0.815, BAYES_00=-5, FORGED_RCVD_HELO=0.266, OPTING_OUT_CAPS=0.483]
X-Spam-Level
Maciek Sieczka via RT wrote:

> Moreover, r.blend ignores --ovewrite flag:
> 
>    $ g.list rast | grep map1_blend
> 
>      map1_blend.b            map1_blend.g
>      map1_blend.r
> 
>    $ r.blend --o first=map1 second=map2 output=map1_blend
>      Raster map <map1_blend.r> already exists.
> 
> *I know* it *exists* - that's why I'm using --o switch; but it's ignored for
> some reason.

r.blend performs its own check for the output maps:

	for MAP in r g b ; do
	   g.findfile elem=cell file=${GIS_OPT_OUTPUT}.$MAP > /dev/null
	   if [ $? -eq 0 ] ; then
	      echo "Raster map <${GIS_OPT_OUTPUT}.$MAP> already exists." 1>&2
	      exit 1
	   fi
	done

I've committed fixes for both issues (checking the base name, ignoring
--overwrite).

-- 
Glynn Clements <glynn@gclements.plus.com>


Tue, Aug 8 2006 19:44:15    Mail sent by guest  
Great, I conform it's fixed now. Closing it.

Thanks,
Maciek
Tue, Aug 8 2006 19:44:48    Status changed to resolved by msieczka  
Comment | Reply | Take | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request