Details Ticket 4757


Comment | Reply | Take | Open


Serial Number 4757
Subject lib/gis/done_msg.c fails
Area grass6
Queue grass
Requestors neteler@itc.it
Owner none
Status resolved
Last User Contact Sat Jul 1 22:02:25 2006 (2 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Sat Jul 1 22:02:28 2006 (2 yr ago)
Created Wed Jun 28 15:37:15 2006 (2 yr ago)

Transaction History Ticket 4757


Wed, Jun 28 2006 15:37:15    Request created by guest  
Subject: lib/gis/done_msg.c fails

grass obtained from: CVS
grass binary for platform: Compiled from Sources

Hi,

both getlogin() and G_whoami() fail in lib/gis/done_msg.c.
It is not clear to me why these functions are needed at all.

Proposal: simplify the function to:

#include <grass/gis.h>
#include <grass/glocale.h>

int G_done_msg(char *msg)
{
        G_message(_("%s complete. %s\n"), G_program_name(), msg);
        return 0;
}


Markus
Wed, Jun 28 2006 19:12:11    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17570.47207.675273.355721@cerise.gclements.plus.com>
Date Wed, 28 Jun 2006 18:12:07 +0100
To Request Tracker <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #4757] (grass) lib/gis/done_msg.c fails
In-Reply-To <20060628133715.3A838100160@lists.intevation.de>
References <20060628133715.3A838100160@lists.intevation.de>
X-Mailer VM 7.07 under 21.4 (patch 15) "Security Through Obscurity" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-3.171 tagged_above=-999 required=4 tests=[AWL=1.563, BAYES_00=-5, FORGED_RCVD_HELO=0.266]
X-Spam-Level
Request Tracker wrote:

> this bug's URL: http://intevation.de/rt/webrt?serial_num=4757
> -------------------------------------------------------------------------
> 
> Subject: lib/gis/done_msg.c fails
> 
> grass obtained from: CVS
> grass binary for platform: Compiled from Sources
> 
> Hi,
> 
> both getlogin() and G_whoami() fail in lib/gis/done_msg.c.
> It is not clear to me why these functions are needed at all.

I suspect that it's to handle the situation where you start a job in
the background, log out, someone else logs in, your background job
completes and writes the completion message to the terminal.

This doesn't actually work on Linux, but I can't find any
documentation which addresses this situation. There isn't any
fundamental reason why a process which has a descriptor for the
terminal can't continue to use the terminal after you've logged out.

The code in G_done_msg() checks whether the user running the process
(as determined by G_whoami()) is the same as the user who is listed in
the utmp file as being logged in on the terminal.

IMHO, getting rid of that check is unlikely to have any adverse
consequences in real use.

-- 
Glynn Clements <glynn@gclements.plus.com>


Fri, Jun 30 2006 18:58:22    Mail sent by neteler@itc.it  
Return-Path <neteler@itc.it>
Delivered-To grass-bugs@lists.intevation.de
Date Fri, 30 Jun 2006 18:58:20 +0200
From Markus Neteler <neteler@itc.it>
To Glynn Clements <glynn@gclements.plus.com>
Cc Request Tracker <grass-bugs@intevation.de>, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #4757] (grass) lib/gis/done_msg.c fails
Message-ID <20060630165819.GF30552@bartok.itc.it>
Mail-Followup-To Glynn Clements <glynn@gclements.plus.com>, Request Tracker <grass-bugs@intevation.de>, grass-dev@grass.itc.it
References <20060628133715.3A838100160@lists.intevation.de> <17570.47207.675273.355721@cerise.gclements.plus.com>
Mime-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
In-Reply-To <17570.47207.675273.355721@cerise.gclements.plus.com>
X-PGP-Key http://www.gdf-hannover.de/neteler/markus_gpgkey.asc
X-PGP-Fingerprint D4D5 2F80 120E AD60 E2F6 2297 21B3 D02B E1E7 E789
User-Agent Mutt/1.5.11
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-3.248 tagged_above=-999 required=4 tests=[AWL=1.486, BAYES_00=-5, FORGED_RCVD_HELO=0.266]
X-Spam-Level
On Wed, Jun 28, 2006 at 06:12:07PM +0100, Glynn Clements wrote:
> 
> Request Tracker wrote:
> 
> > this bug's URL: http://intevation.de/rt/webrt?serial_num=4757
> > -------------------------------------------------------------------------
> > 
> > Subject: lib/gis/done_msg.c fails
> > 
> > grass obtained from: CVS
> > grass binary for platform: Compiled from Sources
> > 
> > Hi,
> > 
> > both getlogin() and G_whoami() fail in lib/gis/done_msg.c.
> > It is not clear to me why these functions are needed at all.
> 
> I suspect that it's to handle the situation where you start a job in
> the background, log out, someone else logs in, your background job
> completes and writes the completion message to the terminal.
> 
> This doesn't actually work on Linux, but I can't find any
> documentation which addresses this situation. There isn't any
> fundamental reason why a process which has a descriptor for the
> terminal can't continue to use the terminal after you've logged out.
> 
> The code in G_done_msg() checks whether the user running the process
> (as determined by G_whoami()) is the same as the user who is listed in
> the utmp file as being logged in on the terminal.
> 
> IMHO, getting rid of that check is unlikely to have any adverse
> consequences in real use.
>

Glynn,

not sure if I interprete your opinion correctly:
Approval for the proposed minimization of lib/gis/done_msg.c?

thanks
  Markus 


Sat, Jul 1 2006 20:46:41    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17574.49926.675610.854660@cerise.gclements.plus.com>
Date Sat, 1 Jul 2006 19:46:30 +0100
To Markus Neteler <neteler@itc.it>
Cc Request Tracker <grass-bugs@intevation.de>, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #4757] (grass) lib/gis/done_msg.c fails
In-Reply-To <20060630165819.GF30552@bartok.itc.it>
References <20060628133715.3A838100160@lists.intevation.de> <17570.47207.675273.355721@cerise.gclements.plus.com> <20060630165819.GF30552@bartok.itc.it>
X-Mailer VM 7.07 under 21.4 (patch 15) "Security Through Obscurity" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-3.193 tagged_above=-999 required=4 tests=[AWL=1.541, BAYES_00=-5, FORGED_RCVD_HELO=0.266]
X-Spam-Level
Markus Neteler wrote:

> > > this bug's URL: http://intevation.de/rt/webrt?serial_num=4757
> > > -------------------------------------------------------------------------
> > > 
> > > Subject: lib/gis/done_msg.c fails
> > > 
> > > grass obtained from: CVS
> > > grass binary for platform: Compiled from Sources
> > > 
> > > Hi,
> > > 
> > > both getlogin() and G_whoami() fail in lib/gis/done_msg.c.
> > > It is not clear to me why these functions are needed at all.
> > 
> > I suspect that it's to handle the situation where you start a job in
> > the background, log out, someone else logs in, your background job
> > completes and writes the completion message to the terminal.
> > 
> > This doesn't actually work on Linux, but I can't find any
> > documentation which addresses this situation. There isn't any
> > fundamental reason why a process which has a descriptor for the
> > terminal can't continue to use the terminal after you've logged out.
> > 
> > The code in G_done_msg() checks whether the user running the process
> > (as determined by G_whoami()) is the same as the user who is listed in
> > the utmp file as being logged in on the terminal.
> > 
> > IMHO, getting rid of that check is unlikely to have any adverse
> > consequences in real use.
> 
> not sure if I interprete your opinion correctly:
> Approval for the proposed minimization of lib/gis/done_msg.c?

Yes.

-- 
Glynn Clements <glynn@gclements.plus.com>


Sat, Jul 1 2006 22:02:25    Mail sent by mneteler  
Change applied.

Markus
Sat, Jul 1 2006 22:02:28    Status changed to resolved by mneteler  
Comment | Reply | Take | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request