Wed, Apr 19 2006
17:50:50
|
|
Request created by guest
|
|
Subject: shaded relief parameter checking
Platform: GNU/Linux/x86_64
grass obtained from: CVS
grass binary for platform: Compiled from Sources
GRASS Version: 6.1
There is a bug in r.shaded.relief where the input parameters are
checked, especially the azimuth.
the current version reads:
================
if test $alt -lt 0 -o $alt -gt 90
then
echo "Sorry, altitude must be greater than 0 and less than 90"
exit 1
fi
if test $az -lt 0 -o $alt -gt 360
then
echo "Sorry, azimuth must be between 0 and 360"
exit 1
fi
================
and it should be according to the text description
================
if test $alt -lt 1 -o $alt -gt 89
then
echo "Sorry, altitude must be greater than 0 and less than 90"
exit 1
fi
if test $az -lt 0 -o $az -gt 360
then
echo "Sorry, azimuth must be between 0 and 360"
exit 1
fi
|
|
Wed, Apr 19 2006
23:46:58
|
|
Mail sent by michael.barton@asu.edu
|
|
Return-Path |
<Michael.Barton@asu.edu>
|
Delivered-To |
grass-bugs@lists.intevation.de
|
Date |
Wed, 19 Apr 2006 14:46:02 -0700
|
From |
Michael Barton <michael.barton@asu.edu>
|
Subject |
Re: [GRASS5] [bug #4311] (grass) shaded relief parameter checking
|
In-reply-to |
<20060419155050.889E210015B@lists.intevation.de>
|
To |
Paolo Cavallini via RT <grass-bugs@intevation.de>, grass5@grass.itc.it
|
Message-id |
<C06BFDAA.20BBD%michael.barton@asu.edu>
|
MIME-version |
1.0
|
Content-type |
text/plain; charset=US-ASCII
|
Content-transfer-encoding |
7bit
|
User-Agent |
Microsoft-Entourage/11.2.3.060209
|
Thread-Topic |
[GRASS5] [bug #4311] (grass) shaded relief parameter checking
|
Thread-Index |
AcZj+qbq5TRB2M/tEdqgWAAUUSYxwg==
|
X-Spam-Status |
No, hits=-4.9 tagged_above=-999.0 required=3.0 tests=BAYES_00
|
X-Spam-Level |
|
I changed the sun angle check error message to match the documentation and
the script code. See below.
Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics and Complexity
Arizona State University
phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton
> From: Request Tracker <grass-bugs@intevation.de>
> Reply-To: Request Tracker <grass-bugs@intevation.de>
> Date: Wed, 19 Apr 2006 17:50:50 +0200 (CEST)
> To: <grass5@grass.itc.it>
> Subject: [GRASS5] [bug #4311] (grass) shaded relief parameter checking
>
> this bug's URL: http://intevation.de/rt/webrt?serial_num=4311
> -------------------------------------------------------------------------
>
> Subject: shaded relief parameter checking
>
> Platform: GNU/Linux/x86_64
> grass obtained from: CVS
> grass binary for platform: Compiled from Sources
> GRASS Version: 6.1
>
> There is a bug in r.shaded.relief where the input parameters are
> checked, especially the azimuth.
>
> the current version reads:
> ================
> if test $alt -lt 0 -o $alt -gt 90
> then
> echo "Sorry, altitude must be greater than 0 and less than 90"
changed to "Sorry, altitude must be between 0 and 90"
> exit 1
> fi
>
> if test $az -lt 0 -o $alt -gt 360
> then
> echo "Sorry, azimuth must be between 0 and 360"
> exit 1
> fi
>
|
|
Thu, Apr 20 2006
05:32:39
|
|
Mail sent by hamish_nospam@yahoo.com
|
|
Return-Path |
<hamish_nospam@yahoo.com>
|
Delivered-To |
grass-bugs@lists.intevation.de
|
Date |
Thu, 20 Apr 2006 15:32:16 +1200
|
From |
Hamish <hamish_nospam@yahoo.com>
|
To |
Michael Barton <michael.barton@asu.edu>
|
Cc |
grass-bugs@intevation.de, grass5@grass.itc.it
|
Subject |
Re: [GRASS5] [bug #4311] (grass) shaded relief parameter checking
|
Message-Id |
<20060420153216.37444c93.hamish_nospam@yahoo.com>
|
In-Reply-To |
<C06BFDAA.20BBD%michael.barton@asu.edu>
|
References |
<20060419155050.889E210015B@lists.intevation.de> <C06BFDAA.20BBD%michael.barton@asu.edu>
|
X-Mailer |
Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
|
X-Face |
M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
|
Mime-Version |
1.0
|
Content-Type |
text/plain; charset=US-ASCII
|
Content-Transfer-Encoding |
7bit
|
X-Spam-Status |
No, hits=-4.0 tagged_above=-999.0 required=3.0 tests=BAYES_00, FORGED_YAHOO_RCVD
|
X-Spam-Level |
|
> > this bug's URL: http://intevation.de/rt/webrt?serial_num=4311
> > -------------------------------------------------------------------
> > ------
> >
> > Subject: shaded relief parameter checking
..
> > There is a bug in r.shaded.relief where the input parameters are
> > checked, especially the azimuth.
> >
> > the current version reads:
> > ================
> > if test $alt -lt 0 -o $alt -gt 90
> > then
> > echo "Sorry, altitude must be greater than 0 and less than
> > 90"
>
> changed to "Sorry, altitude must be between 0 and 90"
>
> > exit 1
> > fi
> >
> > if test $az -lt 0 -o $alt -gt 360
^^^^ ^^^^
actually this was the error.
> > then
> > echo "Sorry, azimuth must be between 0 and 360"
> > exit 1
> > fi
Anyway, those checks should have been in the parameter setup as
#% options : 0-90
to let the parser do its job.
so I've moved them there for both 6.1 and 6.0.x CVS branches.
For this module out-of-bounds values don't fail, so 0-90 or 1-89 really
didn't matter to the output. I think the description was changed to
odd numbers to reflect the broken >,< tests?
also did a few more cleanups in the 6.1 branch. (record metadata, etc)
Hamish
|
|
Thu, Apr 20 2006
05:42:01
|
|
Mail sent by michael.barton@asu.edu
|
|
Return-Path |
<Michael.Barton@asu.edu>
|
Delivered-To |
grass-bugs@lists.intevation.de
|
Date |
Wed, 19 Apr 2006 20:41:52 -0700
|
From |
Michael Barton <michael.barton@asu.edu>
|
Subject |
Re: [GRASS5] [bug #4311] (grass) shaded relief parameter checking
|
In-reply-to |
<20060420153216.37444c93.hamish_nospam@yahoo.com>
|
To |
Hamish <hamish_nospam@yahoo.com>
|
Cc |
Paolo Cavallini via RT <grass-bugs@intevation.de>, grass5@grass.itc.it
|
Message-id |
<C06C5110.9DF5%michael.barton@asu.edu>
|
MIME-version |
1.0
|
Content-type |
text/plain; charset=US-ASCII
|
Content-transfer-encoding |
7bit
|
User-Agent |
Microsoft-Entourage/11.2.3.060209
|
Thread-Topic |
[GRASS5] [bug #4311] (grass) shaded relief parameter checking
|
Thread-Index |
AcZkLFyCmwZNBNAfEdqyNAAKlXAweg==
|
X-Spam-Status |
No, hits=-4.9 tagged_above=-999.0 required=3.0 tests=BAYES_00
|
X-Spam-Level |
|
I see it now. It wasn't clear to me in the bug report.
Thanks for fixing it.
Michael
__________________________________________
Michael Barton, Professor of Anthropology
School of Human Evolution & Social Change
Center for Social Dynamics & Complexity
Arizona State University
phone: 480-965-6213
fax: 480-965-7671
www: http://www.public.asu.edu/~cmbarton
> From: Hamish <hamish_nospam@yahoo.com>
> Date: Thu, 20 Apr 2006 15:32:16 +1200
> To: Michael Barton <michael.barton@asu.edu>
> Cc: <grass-bugs@intevation.de>, <grass5@grass.itc.it>
> Subject: Re: [GRASS5] [bug #4311] (grass) shaded relief parameter checking
>
>>> this bug's URL: http://intevation.de/rt/webrt?serial_num=4311
>>> -------------------------------------------------------------------
>>> ------
>>>
>>> Subject: shaded relief parameter checking
> ..
>>> There is a bug in r.shaded.relief where the input parameters are
>>> checked, especially the azimuth.
>>>
>>> the current version reads:
>>> ================
>>> if test $alt -lt 0 -o $alt -gt 90
>>> then
>>> echo "Sorry, altitude must be greater than 0 and less than
>>> 90"
>>
>> changed to "Sorry, altitude must be between 0 and 90"
>>
>>> exit 1
>>> fi
>>>
>>> if test $az -lt 0 -o $alt -gt 360
>
> ^^^^ ^^^^
> actually this was the error.
>
>>> then
>>> echo "Sorry, azimuth must be between 0 and 360"
>>> exit 1
>>> fi
>
>
> Anyway, those checks should have been in the parameter setup as
> #% options : 0-90
> to let the parser do its job.
>
> so I've moved them there for both 6.1 and 6.0.x CVS branches.
>
> For this module out-of-bounds values don't fail, so 0-90 or 1-89 really
> didn't matter to the output. I think the description was changed to
> odd numbers to reflect the broken >,< tests?
>
> also did a few more cleanups in the 6.1 branch. (record metadata, etc)
>
>
> Hamish
|
|
Thu, Apr 20 2006
05:48:54
|
|
Status changed to resolved by hbowman
|
|