Details Ticket 746


Comment | Reply | Take | Open


Serial Number 746
Subject Change all G_put_map_row() -> G_put_c_raster_row() ?
Area bug
Queue grass
Requestors neteler@geog.uni-hannover.de
Owner none
Status resolved
Last User Contact Tue Jun 12 19:21:06 2001 (7 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Tue Jun 12 19:21:10 2001 (7 yr ago)
Created Tue May 29 10:06:11 2001 (7 yr ago)

Transaction History Ticket 746


Tue, May 29 2001 10:06:11    Request created by mneteler  
Subject: Change all G_put_map_row() -> G_put_c_raster_row() ?

grass downloaded at: CVS Server, Germany

There are still > 70 occurencies of the deprecated function G_put_map_row()
within the sources. Question is to change them to G_put_c_raster_row() for
proper zero/NULL handling:

./src/imagery/i.cca/cmd/transform.c
./src/imagery/i.class/signature.c
./src/imagery/i.composite/compose.c
./src/imagery/i.fft/cmd/fftmain.c
./src/imagery/i.fft/cmd/ifftmain.c   
./src/imagery/i.in.erdas/main.c
./src/imagery/i.ortho.photo/photo.rectify/write.c
./src/imagery/i.pca/cmd/main.c
./src/imagery/i.quantize/compose.c
./src/imagery/i.rectify2/write.c
./src/imagery/i.rgb.his/cmd/h2rmain.c
./src/imagery/i.rgb.his/cmd/putoutput.c
./src/imagery/i.rgb.his/cmd/r2hmain.c
./src/imagery/i.tape.mss/put_row.c
./src/imagery/i.tape.tm/put_row.c
./src/imagery/i.zc/cmd/main.c
./src/libes/gis/opencell.c
./src/libes/gis/put_row.c
./src/libes/gis/TESTS/try2.c
./src/misc/m.lulc.USGS/main.c
./src/raster/r.agnps50/hydro_tools/r.cn/main.c
./src/raster/r.agnps50/hydro_tools/r.weighted.cn/r.weighted.cn.c
./src/raster/r.agnps50/src_agnps_input_1/cell_num_id.c
./src/raster/r.agnps50/src_agnps_input_1/create_grid_map.c
./src/raster/r.agnps50/src_agnps_input_1/drain_num.c   
./src/raster/r.agnps50/src_agnps_input_1/slope_aspect.c
./src/raster/r.agnps50/src_agnps_input_2a/cell_num_id.c
./src/raster/r.agnps50/src_agnps_input_2a/create_grid_map.c
./src/raster/r.agnps50/src_agnps_input_2a/drain_num.c   
./src/raster/r.agnps50/src_agnps_input_2a/slope_aspect.c
./src/raster/r.basins.fill/main.c
./src/raster/r.binfer/engine.c
./src/raster/r.buffer/cmd/write_map.c
./src/raster/r.clump/cmd/clump.c
./src/raster/r.combine/cmd/r_wr_line.c
./src/raster/r.compress/cmd/main.c
./src/raster/r.cross/cross.c   
./src/raster/r.cross/renumber.c 
./src/raster/r.grow/cmd/main.c  
./src/raster/r.in.doq/cmd/main.c
./src/raster/r.in.dted/r.in.dted/bak/read_write.c 
./src/raster/r.in.dted/r.in.dted/dist/read_write.c
./src/raster/r.in.dted/r.in.dted/read_write.c
./src/raster/r.in.ll/cmd/main.c 
./src/raster/r.in.poly/raster.c 
./src/raster/r.in.ppm/r.in.ppm.c
./src/raster/r.in.sunrast/cmd/main.c
./src/raster/r.infer/cmd/run_maps.c
./src/raster/r.los/cmd/main.c
./src/raster/r.mfilter/cmd/perform.c
./src/raster/r.surf.contour/cmd/bseg_write.c
./src/raster/r.surf.contour/cmd/cseg_write.c
./src/raster/r.surf.contour/cmd/main.c  
./src/raster/r.surf.fractal/write_rast.c
./src/raster/r.surf.idw/cmd/main.c 
./src/raster/r.surf.idw2/cmd/main.c
./src/raster/r.thin/cmd/io.c
./src/raster/r.water.outlet/main.c
./src/raster/r.watershed/ram/close_maps.c 
./src/raster/r.watershed/ram/close_maps2.c
./src/raster/r.watershed/seg/bseg_write.c   
./src/raster/r.watershed/seg/close_maps2.c  
./src/raster/r.watershed/seg/cseg_write.c
./src/raster/r.watershed/seg/dseg_write.c
./src/raster/r.weight/inter/execute.c 
./src/raster/wildfire/src/r.ros/main.c
./src/raster/wildfire/src/r.spread/ram2out.c 
./src/raster/wildfire/src/r.spreadpath/main.c
./src.contrib/CERL/imagery/i.rvi.prediction2/main.c
./src.contrib/CERL/imagery/i.shape/zc_curve.c
./src.contrib/CERL/raster/r.hydro.CASC2D/write_files.c
./src.contrib/CERL/raster/r.rvi/main.c
./src.contrib/CERL/raster/r.water.fea/src/inter/shell.c
./src.contrib/NPS/r.in.elas/cmd/main.c
./src.contrib/NPS/r.in.utm/main.c
./src.contrib/SCS/raster/r.out.rlc/main.c

Are there objections to change the functions?

Markus
Tue, May 29 2001 10:32:04    Mail sent by jhickey  
Hi Markus

mneteler wrote (Tue, May 29 2001 10:06:11):

> Subject: Change all G_put_map_row() -> G_put_c_raster_row() ?
> 
> grass downloaded at: CVS Server, Germany
> 
> There are still > 70 occurencies of the deprecated function G_put_map_row()
> within the sources. Question is to change them to G_put_c_raster_row() for
> proper zero/NULL handling:

Is there a G_put_raster_row(..., ..., dtatType) function? If so you should
change the calls to G_put_raster_row(..., ..., CELL) instead. These types of
functions modularize the code. The G_put_[cfd]_raster_row() functions should
become static functions of whatever file they are in. That is, all calls that
want to put a raster row should call G_put_raster_row(..., ..., dtatType)
which in turn calls the appropriate static G_put_[cfd]_raster_row() function.
My todo list includes doing this for the null_val.c since I already made some
changes to that file. I just didn't have time to go through the code and
change the calls yet.

Anyway, that's just my 2 cents worth.

Justin Hickey

PS Sorry about the duplicate Markus, but I don't think I can change the "reply
to" field in RT
Tue, May 29 2001 14:22:36    Mail sent by neteler@geog.uni-hannover.de  
Return-Path <neteler@geog.uni-hannover.de>
Delivered-To grass-bugs@mailman.intevation.de
Date Tue, 29 May 2001 13:51:53 +0100
From Markus Neteler <neteler@geog.uni-hannover.de>
To Justin Hickey via RT <grass-bugs@intevation.de>
Cc grass5 developers list <grass5@geog.uni-hannover.de>
Subject Re: [GRASS5] [bug #746] (grass) Change all G_put_map_row() -> G_put_c_raster_row() ?
Message-ID <20010529135153.I18447@hgeo02.geog.uni-hannover.de>
Mail-Followup-To Justin Hickey via RT <grass-bugs@intevation.de>, grass5 developers list <grass5@geog.uni-hannover.de>
References <20010529083205.90D01139EE@mailman.intevation.de>
Mime-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.2.5i
In-Reply-To <20010529083205.90D01139EE@mailman.intevation.de>; from grass-bugs@intevation.de on Tue, May 29, 2001 at 10:32:05AM +0200
On Tue, May 29, 2001 at 10:32:05AM +0200, Justin Hickey via RT wrote:
> Hi Markus
> 
> mneteler wrote (Tue, May 29 2001 10:06:11):
> 
> > Subject: Change all G_put_map_row() -> G_put_c_raster_row() ?
> > 
> > grass downloaded at: CVS Server, Germany
> > 
> > There are still > 70 occurencies of the deprecated function G_put_map_row()
> > within the sources. Question is to change them to G_put_c_raster_row() for
> > proper zero/NULL handling:
> 
> Is there a G_put_raster_row(..., ..., dtatType) function? If so you should
> change the calls to G_put_raster_row(..., ..., CELL) instead. These types of
> functions modularize the code. The G_put_[cfd]_raster_row() functions should
> become static functions of whatever file they are in. That is, all calls that
> want to put a raster row should call G_put_raster_row(..., ..., dtatType)
> which in turn calls the appropriate static G_put_[cfd]_raster_row() function.
Hi Justin,

Ok, so we would have the change

G_put_map_row() ->  G_put_raster_row(..., ..., , CELL_TYPE);

If no objections, I will change all the 77 occurencies.

> My todo list includes doing this for the null_val.c since I already made some
> changes to that file. I just didn't have time to go through the code and
> change the calls yet.
> 
> Anyway, that's just my 2 cents worth.
> 
> Justin Hickey
> 
> PS Sorry about the duplicate Markus, but I don't think I can change the
> "reply to" field in RT

You can simply write to "grass5" and cc to "grass-bugs@intevation.de". Then
RT will catch the mail and add to the bug. No need to enter the RT for such
communication [this will be the test :-) ]

Cheers

 Markus


Tue, Jun 12 2001 19:21:06    Mail sent by mneteler  
All changes done. seems still to work :-)

Markus
Tue, Jun 12 2001 19:21:10    Status changed to resolved by mneteler  
Comment | Reply | Take | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request