Details Ticket 2952


Comment | Reply | Take | Resolve


Serial Number 2952
Subject i.rectify and photo.rectify: merge bugfixes; switch to GDAL warp API?
Area wish6
Queue grass
Requestors hamish_nospam@yahoo.com
Owner none
Status open
Last User Contact Fri Sep 16 11:43:15 2005 (3 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Sat Sep 17 16:29:27 2005 (3 yr ago)
Created Mon Jan 31 08:12:02 2005 (4 yr ago)

Transaction History Ticket 2952


Mon, Jan 31 2005 08:12:02    Request created by hbowman  
Subject: i.rectify and photo.rectify: merge bugfixes

i.rectify and i.ortho.photo/photo.rectify share mostly the same code. Both
have gotten some bug fixes which have not been applied to both.

speficically by scanning the CVS changelogs:

from i.rectify:
cmd mode code? (perhaps redundant)

from photo.rectify rev 1.1.1.1.4.1:
changed elev reading from CELL to any raster_type 


even better, merge both sets of code into one.


Hamish
Mon, Jan 31 2005 23:25:26    Mail sent by neteler@itc.it  
Return-Path <neteler@itc.it>
Delivered-To grass-bugs@lists.intevation.de
Date Mon, 31 Jan 2005 23:25:23 +0100
From Markus Neteler <neteler@itc.it>
To Request Tracker <grass-bugs@intevation.de>
Cc grass5@grass.itc.it
Subject Re: [GRASS5] [bug #2952] (grass) i.rectify and photo.rectify: merge bugfixes
Message-ID <20050131222523.GD25048@thuille.itc.it>
Mail-Followup-To Request Tracker <grass-bugs@intevation.de>, grass5@grass.itc.it
References <20050131071203.0A002102BED@lists.intevation.de>
Mime-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
In-Reply-To <20050131071203.0A002102BED@lists.intevation.de>
User-Agent Mutt/1.4.1i
X-Spam-Status No, hits=-4.9 tagged_above=-999.0 required=3.0 tests=BAYES_00
X-Spam-Level
On Mon, Jan 31, 2005 at 08:12:03AM +0100, Request Tracker wrote:
> this bug's URL: http://intevation.de/rt/webrt?serial_num=2952
> -------------------------------------------------------------------------
> 
> Subject: i.rectify and photo.rectify: merge bugfixes
> 
> i.rectify and i.ortho.photo/photo.rectify share mostly the same code. Both
> have gotten some bug fixes which have not been applied to both.
> 
> speficically by scanning the CVS changelogs:
> 
> from i.rectify:
> cmd mode code? (perhaps redundant)
> 
> from photo.rectify rev 1.1.1.1.4.1:
> changed elev reading from CELL to any raster_type 
> 
> 
> even better, merge both sets of code into one.

Sort of agreed.
Please have a look at TODO in the main G6 CVS.
I have recently added a proposal to improve the image processing
library. Currently I try to organize something (offlist).

Contributors welcome

 Markus


Thu, Feb 3 2005 01:28:07    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Thu, 3 Feb 2005 13:27:50 +1300
From Hamish <hamish_nospam@yahoo.com>
To grass5 <grass5@grass.itc.it>
Cc Request Tracker <grass-bugs@intevation.de>
Subject Re: [GRASS5] [bug #2952] (grass) i.rectify and photo.rectify: merge bugfixes
Message-Id <20050203132750.0a9120a3.hamish_nospam@yahoo.com>
X-Mailer Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Spam-Status No, hits=-4.0 tagged_above=-999.0 required=3.0 tests=BAYES_00, FORGED_YAHOO_RCVD
X-Spam-Level
> this bug's URL: http://intevation.de/rt/webrt?serial_num=2952
> ---------------------------------------------------------------------


Hi,


I have removed the email code from i.rectify and i.ortho.photo/photo.rectify
It should work like a normal module now.

please test. soon. especially i.ortho which I can't test.



thanks,
Hamish


Thu, Feb 3 2005 12:11:28    Mail sent by neteler@itc.it  
Return-Path <neteler@itc.it>
Delivered-To grass-bugs@lists.intevation.de
Date Thu, 3 Feb 2005 12:11:19 +0100
From Markus Neteler <neteler@itc.it>
To Hamish <hamish_nospam@yahoo.com>
Cc grass5 <grass5@grass.itc.it>, Request Tracker <grass-bugs@intevation.de>
Subject Re: [GRASS5] [bug #2952] (grass) i.rectify and photo.rectify: merge bugfixes
Message-ID <20050203111119.GN28476@thuille.itc.it>
Mail-Followup-To Hamish <hamish_nospam@yahoo.com>, grass5 <grass5@grass.itc.it>, Request Tracker <grass-bugs@intevation.de>
References <20050203132750.0a9120a3.hamish_nospam@yahoo.com>
Mime-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
In-Reply-To <20050203132750.0a9120a3.hamish_nospam@yahoo.com>
User-Agent Mutt/1.4.1i
X-Spam-Status No, hits=-4.9 tagged_above=-999.0 required=3.0 tests=BAYES_00
X-Spam-Level
On Thu, Feb 03, 2005 at 01:27:50PM +1300, Hamish wrote:
> > this bug's URL: http://intevation.de/rt/webrt?serial_num=2952
> > ---------------------------------------------------------------------
> 
> 
> Hi,
> 
> 
> I have removed the email code from i.rectify and i.ortho.photo/photo.rectify
> It should work like a normal module now.
> 
> please test. soon. especially i.ortho which I can't test.

This was IMHO not a good idea.
i.ortho.photo/photo.rectify and i.rectify were known to be working.

We cannot break things during the beta cycle. Why submitting now
and not when the 6.0 branch is opened?

To test such complicated things is quite impossible in one day.
We are pretty close to beta2 and now i.rectify and i.ortho.photo
are probably broken and will go broken into 6.0.0.

My suggestion is to revert this change and to submit later.
 
Markus


Thu, Feb 3 2005 23:30:37    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Fri, 4 Feb 2005 11:30:23 +1300
From Hamish <hamish_nospam@yahoo.com>
To Markus Neteler <neteler@itc.it>
Cc grass5@grass.itc.it, grass-bugs@intevation.de
Subject Re: [GRASS5] [bug #2952] (grass) i.rectify and photo.rectify: merge bugfixes
Message-Id <20050204113023.2557b5c5.hamish_nospam@yahoo.com>
In-Reply-To <20050203111119.GN28476@thuille.itc.it>
References <20050203132750.0a9120a3.hamish_nospam@yahoo.com> <20050203111119.GN28476@thuille.itc.it>
X-Mailer Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Spam-Status No, hits=-4.0 tagged_above=-999.0 required=3.0 tests=BAYES_00, FORGED_YAHOO_RCVD
X-Spam-Level
> > I have removed the email code from i.rectify and
> > i.ortho.photo/photo.rectify It should work like a normal module now.
> > 
> > please test. soon. especially i.ortho which I can't test.
> 
> This was IMHO not a good idea.
> i.ortho.photo/photo.rectify and i.rectify were known to be working.
> 
> We cannot break things during the beta cycle. Why submitting now
> and not when the 6.0 branch is opened?

I asked on the list & waited a few days with no replies.....

 
> To test such complicated things is quite impossible in one day.
> We are pretty close to beta2 and now i.rectify and i.ortho.photo
> are probably broken and will go broken into 6.0.0.
> 
> My suggestion is to revert this change and to submit later.


That is fine with me.

I would ask that someone else revert the change in CVS though as I have
about 20 minutes of time left at the computer before monday/tuesday.



Hamish


Fri, Feb 4 2005 03:41:33    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Fri, 4 Feb 2005 15:41:17 +1300
From Hamish <hamish_nospam@yahoo.com>
To Hamish <hamish_nospam@yahoo.com>
Cc neteler@itc.it, grass5@grass.itc.it, grass-bugs@intevation.de
Subject Re: [GRASS5] [bug #2952] (grass) i.rectify and photo.rectify: merge bugfixes
Message-Id <20050204154117.5a379a9b.hamish_nospam@yahoo.com>
In-Reply-To <20050204113023.2557b5c5.hamish_nospam@yahoo.com>
References <20050203132750.0a9120a3.hamish_nospam@yahoo.com> <20050203111119.GN28476@thuille.itc.it> <20050204113023.2557b5c5.hamish_nospam@yahoo.com>
X-Mailer Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Spam-Status No, hits=-4.0 tagged_above=-999.0 required=3.0 tests=BAYES_00, FORGED_YAHOO_RCVD
X-Spam-Level
> > > I have removed the email code from i.rectify and
> > > i.ortho.photo/photo.rectify It should work like a normal module now.
..
> > My suggestion is to revert this change and to submit later.
>
> That is fine with me.
> 
> I would ask that someone else revert the change in CVS though as I have
> about 20 minutes of time left at the computer before monday/tuesday.


I've found some time; both i.rectify & photo.rectify reverted now in CVS.

I've left in some #includes and function prototypes which were missing.

imagery/i.rectify
imagery/i.ortho.photo/photo.rectify


You can review the changes since 6.0beta1 with:

$ cd imagery/i.rectify
$ cvs update
$ cvs diff -r grass_6_0_0_beta_1


etc




Hamish


Fri, Sep 16 2005 11:43:15    Mail sent by msieczka  
Hi,

As I understand Hamish reverted his changes in "the email code from i.rectify
and i.ortho.photo/photo.rectify" for 6beta1 but they are present in 6.1. Right?
What is the status of the original wish subject - merging bugfixes done for
i.rectify and photo.rectify. Does this wish still aplly to 6.1?

Maciek
Fri, Sep 16 2005 13:57:48    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Fri, 16 Sep 2005 23:57:31 +1200
From Hamish <hamish_nospam@yahoo.com>
To Maciek Sieczka via RT <grass-bugs@intevation.de>
Cc grass5@grass.itc.it, neteler@itc.it
Subject Re: [GRASS5] [bug #2952] (grass) i.rectify and photo.rectify: merge bugfixes
Message-Id <20050916235731.3636ad5b.hamish_nospam@yahoo.com>
In-Reply-To <20050916094315.EDB651006BA@lists.intevation.de>
References <20050916094315.EDB651006BA@lists.intevation.de>
X-Mailer Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Spam-Status No, hits=-4.0 tagged_above=-999.0 required=3.0 tests=BAYES_00, FORGED_YAHOO_RCVD
X-Spam-Level
> What is the status of the original wish subject - merging bugfixes
> done for i.rectify and photo.rectify. Does this wish still aplly to
> 6.1?


Yes it does.

It would be good I think to use the GDAL warp API to do the hard work.
Much of it is the same code as GRASS uses with the difference that the
GDAL code is better maintained and more featureful (eg thin plate
splines). GRASS now depends on GDAL, so versioning issues aside this
should be possible.

http://www.gdal.org/warptut.html




Hamish


Sat, Sep 17 2005 16:28:57    Subject changed to i.rectify and photo.rectify: merge bugfixes; switch to GDAL warp API? by msieczka  
Sat, Sep 17 2005 16:29:27    Area changed to wish6 by msieczka  
Comment | Reply | Take | Resolve

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request