Details Ticket 2252


Comment | Reply | Take | Resolve


Serial Number 2252
Subject v.vol.rst error checks
Area grass6
Queue grass
Requestors webmaster@weather.nmsu.edu
Owner none
Status open
Last User Contact Wed Dec 17 18:32:25 2003 (5 yr ago)
Current Priority 20
Final Priority 70
Due No date assigned
Last Action Tue Jun 19 12:34:18 2007 (1 yr ago)
Created Tue Dec 16 18:56:08 2003 (5 yr ago)

Transaction History Ticket 2252


Tue, Dec 16 2003 18:56:08    Request created by guest  
Subject: s.vol.rst segfaults

Platform: GNU/Linux/i386
grass obtained from: Trento Italy site
grass binary for platform: Compiled from Sources
GRASS Version: 5.0.2

s.vol.rst gives a segfault when loading WIND3 or DEFAULT_WIND3 if their format
isn't exactly right or if the file being loaded is empty.  I recognize that an
empty 
configuration file isn't the best thing to have, but a segfault isn't the best
way to 
deal with it either. 
I believe that this problem is in G3d_readWindow() (in g3dwindowio.c), but I
haven't played with it enough to confirm this. 
 
Also, on the subject of s.vol.rst, it would be nice to put in an exit(1) or some
such 
if G3d_readWindow() fails (returns 0) at the start (line 189 in main.c): I can't
think 
of anything good which can come from s.vol.rst continuing without a region 
defined. 
Wed, Dec 17 2003 18:32:25    Mail sent by smitchell  
Making your suggested change to g3dwindowio.c did in fact get rid of the segfault.
Other issues in s.vol.rst still outstanding.
Fri, Jan 23 2004 19:07:57    Priority changed to 20 by bernhard  
Tue, Jun 19 2007 12:33:43    Comments added by hbowman  
GRASS 6.3-cvs June 2007:

still needs a check + G_fatal_error() added here:


vector/v.vol.rst/main.c
...
    if (G_get_set_window (&cellhd) == -1)
      G_fatal_error("G_get_set_window() failed"); 

    G3d_getWindow (¤t_region);
    G3d_readWindow(¤t_region,NULL);



Hamish
Tue, Jun 19 2007 12:34:07    Subject changed to v.vol.rst error checks by hbowman  
Tue, Jun 19 2007 12:34:18    Area changed to grass6 by hbowman  
Comment | Reply | Take | Resolve

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request