Details Ticket 3069


Comment | Reply | Take | Open


Serial Number 3069
Subject r.mapcalc - warning/errorr amibiguity
Area grass6
Queue grass
Requestors tutey@o2.pl
Owner none
Status resolved
Last User Contact Tue Mar 6 23:16:02 2007 (1 yr ago)
Current Priority 30
Final Priority 70
Due No date assigned
Last Action Tue Mar 6 23:16:02 2007 (1 yr ago)
Created Fri Mar 4 18:10:55 2005 (3 yr ago)

Transaction History Ticket 3069


Fri, Mar 4 2005 18:10:55    Request created by guest  
Subject: r.mapcalc - warning/errorr amibiguity

Platform: GNU/Linux/i386
grass obtained from: Mirror of Trento site
grass binary for platform: Compiled from Sources
GRASS Version: grass-6.0.cvs_src_snapshot_2005_02_12

Ambiguity - either WARNING or ERROR, why both?

GRASS 6.0.cvs:~ > r.mapcalc 'lake=kpn65'
WARNING: 'cell/kpn65' was found in more mapsets (also found in topo).
ERROR: 'cell/kpn65' was found in more mapsets (also found in topo).

Maciek
Fri, Sep 2 2005 18:55:14    User changed to werchowyna@epf.pl by msieczka  
Tue, Jul 18 2006 18:25:38    User changed to tutey@o2.pl by msieczka  
Tue, Jul 18 2006 18:28:19    Mail sent by msieczka  
Maciek Sieczka wrote (Fri, Mar 4 2005 18:10:55):

> GRASS 6.0.cvs:~ > r.mapcalc 'lake=kpn65'
> WARNING: 'cell/kpn65' was found in more mapsets (also found in topo).
> ERROR: 'cell/kpn65' was found in more mapsets (also found in topo).

This is still a bug. Not serious at all for a Grass whiz, but 6.1 newbies will
be scared. I think WARNING will be enough (at least not both warning and error).
Maciek
Wed, Jul 19 2006 21:05:27    Mail sent by tutey@o2.pl  
Return-Path <tutey@o2.pl>
Delivered-To grass-bugs@lists.intevation.de
Message-ID <44BE8274.8030804@o2.pl>
Date Wed, 19 Jul 2006 21:05:24 +0200
From Maciej Sieczka <tutey@o2.pl>
User-Agent Thunderbird 1.5.0.4 (X11/20060615)
MIME-Version 1.0
To Hamish <hamish_nospam@yahoo.com>
Cc Maciek Sieczka via RT <grass-bugs@intevation.de>, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #3069] (grass) r.mapcalc - warning/errorr amibiguity
References <20060718162819.CBA5E1005C9@lists.intevation.de> <20060719143850.61916691.hamish_nospam@yahoo.com>
In-Reply-To <20060719143850.61916691.hamish_nospam@yahoo.com>
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 8bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, hits=-4.734 tagged_above=-999 required=3 tests=[BAYES_00=-5, FORGED_RCVD_HELO=0.266]
X-Spam-Level
Hamish napisa?(a):
>>> GRASS 6.0.cvs:~ > r.mapcalc 'lake=kpn65'
>>> WARNING: 'cell/kpn65' was found in more mapsets (also found in topo).
>>> ERROR: 'cell/kpn65' was found in more mapsets (also found in topo).
>> This is still a bug. Not serious at all for a Grass whiz, but 6.1
>> newbies will be scared. I think WARNING will be enough (at least not
>> both warning and error).
> 
> 
> g.mapsets includes "topo" as a secondary mapset in the path?

I don't have this particular location at hand now, so I'll use another
one, OK? I hope the commands below will explain enough:

$ g.mapsets -p
nic PERMANENT

$ g.gisenv
GISDBASE=/home/grassdata
LOCATION_NAME=xy
MAPSET=nic
GRASS_GUI=text

$ g.list rast
----------------------------------------------
raster files available in mapset nic:
map

raster files available in mapset PERMANENT:
map

----------------------------------------------

$ r.mapcalc 'map2=map'
WARNING: 'cell/map' was found in more mapsets (also found in nic).
ERROR: 'cell/map' was found in more mapsets (also found in nic).


$ g.list rast
----------------------------------------------
raster files available in mapset nic:
map

raster files available in mapset PERMANENT:
map

----------------------------------------------



And so the 'map2' is not created as you can see...

I though about this once more, and I'm wondering:

Should only error be issued and information that implicit '@mapset' has
to be put for r.mapcalc to work in case of identical names?

Or should r.mapcalc default to 'map' in the current mapset, issuing a
warning only that an identical raster exists in other mapset/s?

The firt approach looks more user-error proof (paranoid?), the latter
will be more convenient in daily use.

How do other modules handle identical names in different mapsets? (I
guess they default to current mapset and don't even care for other
mapsets, unless implicit @mapset is used...).

Maciek


Mon, Mar 5 2007 21:14:24    Mail sent by msieczka  
r.mapcalc still prints this double information in case 2 same called rasters
exit within the accesible mapsets, eg.:

WARNING: 'cell/map' was found in more mapsets (also found in nic).
ERROR: 'cell/map' was found in more mapsets (also found in nic).

Moreover, in such case r.mapcalc exits with status 1. Could it be bad for scripts?
Maciek
Mon, Mar 5 2007 23:39:45    Mail sent by hamish_nospam@yahoo.com  
Return-Path <hamish_nospam@yahoo.com>
Delivered-To grass-bugs@lists.intevation.de
Date Tue, 6 Mar 2007 11:24:29 +1300
From Hamish <hamish_nospam@yahoo.com>
To Maciek Sieczka via RT <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #3069] (grass) r.mapcalc - warning/errorr amibiguity
Message-Id <20070306112429.203104e3.hamish_nospam@yahoo.com>
In-Reply-To <20070305201424.1ECE81006A3@lists.intevation.de>
References <20070305201424.1ECE81006A3@lists.intevation.de>
X-Mailer Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-pc-linux-gnu)
X-Face M<EoB)"*Z~u!,vFhXmw}R_KbdBta*P_=T|rbBL'e1/CQ9;/1g\BU3&!=y8ria$2Uk!HT&BB 8i?|X_+7~1jsy}F~g$2va%3fV`*=L(*cem[@3\yg,G,@rg6/QMJ
Mime-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, score=0.204 tagged_above=-999 required=3 tests=[BAYES_00=-5, DNS_FROM_RFC_ABUSE=0.2, DNS_FROM_RFC_POST=1.708, DNS_FROM_RFC_WHOIS=1.447, FORGED_YAHOO_RCVD=1.849]
X-Spam-Score 0.204
X-Spam-Level
Maciek Sieczka via RT wrote:
> 
> r.mapcalc still prints this double information in case 2 same called
> rasters exit within the accesible mapsets, eg.:
> 
> WARNING: 'cell/map' was found in more mapsets (also found in nic).
> ERROR: 'cell/map' was found in more mapsets (also found in nic).
> 
> Moreover, in such case r.mapcalc exits with status 1. Could it be bad
> for scripts?

(not commenting on the bug, just the symptoms)

exit code of 1 is appropriate if the module exited with an ERROR.

If the system found an ambiguity, it is better to stop with an error
than pick the wrong map and potentially mess up the data without the
user noticing.


Hamish


Tue, Mar 6 2007 03:06:22    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17900.52380.109898.776650@cerise.gclements.plus.com>
Date Tue, 6 Mar 2007 02:06:20 +0000
To Maciek Sieczka via RT <grass-bugs@intevation.de>
Cc grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #3069] (grass) r.mapcalc - warning/errorr amibiguity
In-Reply-To <20070305201424.1ECE81006A3@lists.intevation.de>
References <20070305201424.1ECE81006A3@lists.intevation.de>
X-Mailer VM 7.07 under 21.4 (patch 20) "Double Solitaire" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, score=-4.665 tagged_above=-999 required=3 tests=[BAYES_00=-5, DNS_FROM_RFC_ABUSE=0.2, FORGED_RCVD_HELO=0.135]
X-Spam-Score -4.665
X-Spam-Level
Maciek Sieczka via RT wrote:

> r.mapcalc still prints this double information in case 2 same called rasters
> exit within the accesible mapsets, eg.:
> 
> WARNING: 'cell/map' was found in more mapsets (also found in nic).
> ERROR: 'cell/map' was found in more mapsets (also found in nic).

r.mapcalc uses G_set_error_routine() to install an error handler; the
error handler calls G_fatal_error() regardless of the value of the
"fatal" argument.

I'll fix this.

> Moreover, in such case r.mapcalc exits with status 1. Could it be bad for scripts?
This is correct for an error.

-- 
Glynn Clements <glynn@gclements.plus.com>


Tue, Mar 6 2007 09:42:17    Mail sent by mlennert@club.worldonline.be  
Return-Path <mlennert@club.worldonline.be>
Delivered-To grass-bugs@lists.intevation.de
Message-ID <45ED2A0D.4090403@club.worldonline.be>
Date Tue, 06 Mar 2007 09:45:01 +0100
From Moritz Lennert <mlennert@club.worldonline.be>
User-Agent Icedove 1.5.0.9 (X11/20061220)
MIME-Version 1.0
To Hamish <hamish_nospam@yahoo.com>
Cc Maciek Sieczka via RT <grass-bugs@intevation.de>, grass-dev@grass.itc.it, Glynn Clements <glynn@gclements.plus.com>
Subject Re: [GRASS-dev] [bug #3069] (grass) r.mapcalc - warning/errorr amibiguity
References <20070305201424.1ECE81006A3@lists.intevation.de> <20070306112429.203104e3.hamish_nospam@yahoo.com>
In-Reply-To <20070306112429.203104e3.hamish_nospam@yahoo.com>
Content-Type text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, score=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Score -5
X-Spam-Level
On 05/03/07 23:24, Hamish wrote:
> Maciek Sieczka via RT wrote:
>> r.mapcalc still prints this double information in case 2 same called
>> rasters exit within the accesible mapsets, eg.:
>>
>> WARNING: 'cell/map' was found in more mapsets (also found in nic).

As I've mentioned before somewhere, I find this message a bit confusing, 
especially the "also found in" which normally gives me the mapset I am 
in and want to use the map of (at least it does so when in mapset user1 
of spearfish working on a local copy of a map which is also in PERMANENT).

Couldn't this be changed so that it mentions the _other_ mapsets the map 
is in, and maybe mention which map is used by default (I know that in 
this case it stops with an error, but many other modules just emit this 
as a warning, leaving the user uninformed of which map was used) ?

Moritz


Tue, Mar 6 2007 11:45:33    Mail sent by glynn@gclements.plus.com  
Return-Path <glynn@gclements.plus.com>
Delivered-To grass-bugs@lists.intevation.de
From Glynn Clements <glynn@gclements.plus.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding 7bit
Message-ID <17901.17992.96494.722986@cerise.gclements.plus.com>
Date Tue, 6 Mar 2007 10:45:28 +0000
To Moritz Lennert <mlennert@club.worldonline.be>
Cc Hamish <hamish_nospam@yahoo.com>, Maciek Sieczka via RT <grass-bugs@intevation.de>, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #3069] (grass) r.mapcalc - warning/errorr amibiguity
In-Reply-To <45ED2A0D.4090403@club.worldonline.be>
References <20070305201424.1ECE81006A3@lists.intevation.de> <20070306112429.203104e3.hamish_nospam@yahoo.com> <45ED2A0D.4090403@club.worldonline.be>
X-Mailer VM 7.07 under 21.4 (patch 20) "Double Solitaire" XEmacs Lucid
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, score=-4.665 tagged_above=-999 required=3 tests=[BAYES_00=-5, DNS_FROM_RFC_ABUSE=0.2, FORGED_RCVD_HELO=0.135]
X-Spam-Score -4.665
X-Spam-Level
Moritz Lennert wrote:

> >> r.mapcalc still prints this double information in case 2 same called
> >> rasters exit within the accesible mapsets, eg.:
> >>
> >> WARNING: 'cell/map' was found in more mapsets (also found in nic).
> 
> As I've mentioned before somewhere, I find this message a bit confusing, 
> especially the "also found in" which normally gives me the mapset I am 
> in and want to use the map of (at least it does so when in mapset user1 
> of spearfish working on a local copy of a map which is also in PERMANENT).
> 
> Couldn't this be changed so that it mentions the _other_ mapsets the map 
> is in, and maybe mention which map is used by default (I know that in 
> this case it stops with an error, but many other modules just emit this 
> as a warning, leaving the user uninformed of which map was used) ?

I've changed it so that it identifies all of the mapsets involved,
e.g.:

	$ r.resample in=fields out=fields
	Creating support files for fields...
	creating new cats file...
	$ r.mapcalc foo = fields
	WARNING: 'cell/fields' was found in more mapsets (also found in PERMANENT).
WARNING: using 'fields@glynn'.

-- 
Glynn Clements <glynn@gclements.plus.com>


Tue, Mar 6 2007 11:56:59    Mail sent by mlennert@club.worldonline.be  
Return-Path <mlennert@club.worldonline.be>
Delivered-To grass-bugs@lists.intevation.de
Message-ID <45ED49A1.5040002@club.worldonline.be>
Date Tue, 06 Mar 2007 11:59:45 +0100
From Moritz Lennert <mlennert@club.worldonline.be>
User-Agent Icedove 1.5.0.9 (X11/20061220)
MIME-Version 1.0
To Glynn Clements <glynn@gclements.plus.com>
Cc Hamish <hamish_nospam@yahoo.com>, Maciek Sieczka via RT <grass-bugs@intevation.de>, grass-dev@grass.itc.it
Subject Re: [GRASS-dev] [bug #3069] (grass) r.mapcalc - warning/errorr amibiguity
References <20070305201424.1ECE81006A3@lists.intevation.de> <20070306112429.203104e3.hamish_nospam@yahoo.com> <45ED2A0D.4090403@club.worldonline.be> <17901.17992.96494.722986@cerise.gclements.plus.com>
In-Reply-To <17901.17992.96494.722986@cerise.gclements.plus.com>
Content-Type text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding 7bit
X-Virus-Scanned by amavisd-new at intevation.de
X-Spam-Status No, score=-5 tagged_above=-999 required=3 tests=[BAYES_00=-5]
X-Spam-Score -5
X-Spam-Level
On 06/03/07 11:45, Glynn Clements wrote:
> Moritz Lennert wrote:
> 
>>>> r.mapcalc still prints this double information in case 2 same called
>>>> rasters exit within the accesible mapsets, eg.:
>>>>
>>>> WARNING: 'cell/map' was found in more mapsets (also found in nic).
>> As I've mentioned before somewhere, I find this message a bit confusing, 
>> especially the "also found in" which normally gives me the mapset I am 
>> in and want to use the map of (at least it does so when in mapset user1 
>> of spearfish working on a local copy of a map which is also in PERMANENT).
>>
>> Couldn't this be changed so that it mentions the _other_ mapsets the map 
>> is in, and maybe mention which map is used by default (I know that in 
>> this case it stops with an error, but many other modules just emit this 
>> as a warning, leaving the user uninformed of which map was used) ?
> 
> I've changed it so that it identifies all of the mapsets involved,
> e.g.:
> 
> 	$ r.resample in=fields out=fields
> 	Creating support files for fields...
> 	creating new cats file...
> 	$ r.mapcalc foo = fields
> 	WARNING: 'cell/fields' was found in more mapsets (also found in PERMANENT).
> 	WARNING: using 'fields@glynn'.
> 

Great, thanks !

Moritz


Tue, Mar 6 2007 23:16:02    Status changed to resolved by msieczka  
Tue, Mar 6 2007 23:16:02    Mail sent by msieczka  
Works like a charm. Closing ticket.

Maciek
Comment | Reply | Take | Open

You are currently authenticated as guest.
[Show Configuration] [Login as another user]

Users Guide - Mail Commands - Homepage of RequestTracker 1.0.7 - list any request